Skip to content

⚡ Bolt: Optimize search term parsing overhead#538

Open
seonghobae wants to merge 1 commit into
mainfrom
bolt/search-optimization-13523988109058069167
Open

⚡ Bolt: Optimize search term parsing overhead#538
seonghobae wants to merge 1 commit into
mainfrom
bolt/search-optimization-13523988109058069167

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

💡 What:
Moved the parsing logic for search string out of tableNodeMatchesSearch which executes on every table node to execute only once per findSearchMatchedNodeIds execution.

🎯 Why:
The parsing logic creates an array from a set, running string trims and regex splits which allocates multiple arrays. Doing this inside the main query loop for every table node is $O(N)$ runtime. By hoisting it outside the loop, it brings the execution time for the string splitting down to $O(1)$.

📊 Impact:
Significantly reduces garbage collection overhead and intermediate array allocations during live search filtering on large table schemas. Reduces redundant parsing by a factor equal to the amount of nodes on the ERD canvas.

🔬 Measurement:
Run the frontend test suite. Test execution passes cleanly without functionally modifying the output.


PR created automatically by Jules for task 13523988109058069167 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant