Skip to content

test(frontend): stabilize async coverage orchestration#559

Merged
seonghobae merged 3 commits into
mainfrom
agent/stabilize-async-coverage-tests
Jul 13, 2026
Merged

test(frontend): stabilize async coverage orchestration#559
seonghobae merged 3 commits into
mainfrom
agent/stabilize-async-coverage-tests

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Summary

  • wait for project and diagram rows before opening snapshots or enabling fake timers
  • wait for selected-project snapshot data before asserting search branches
  • prove the first project metadata requests started, then switch projects before rejecting them so the stale-response guard is tested deterministically

Current-head failure evidence

This base stabilization addresses repeated frontend/src/App.coverage.test.tsx failures observed on dependency/feature PR current heads:

The failures are base-owned asynchronous test races, so this PR fixes the shared base once rather than duplicating the same patch across dependency branches.

Validation

  • RED reproduced on main: navigates dashboard... failed at line 328 with the pre-load empty state.
  • focused test repeated three times: 17/17 passed each run.
  • latest-base focused test: 17/17 passed.
  • full frontend coverage: 25 files, 183 tests passed; statements 1400/1400, branches 1052/1052, functions 315/315, lines 1260/1260 (all 100%).
  • production build: passed.
  • git diff --check: passed.
  • CodeGraph initialized before analysis and synchronized after the edit.

Local coverage validation used --testTimeout=10000 because this workstation has Node 24 while the repository declares Node >=26 <27; no timeout or coverage policy was weakened in the repository.

This is test-only stabilization, so no academic-paper artifact is applicable.

@opencode-agent

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 2d4ec3b8776b4f76f3185bae3ad15786ecdf5228
  • Workflow run: 29216912110
  • Workflow attempt: 1
  • Gate result: APPROVE (approval step)

Pull request overview

OpenCode model providers were unavailable for this same-head run, but deterministic current-head evidence is clean: coverage evidence passed, peer GitHub Checks are complete, medium-or-higher code-scanning alerts are clear, mergeability is clean, and reviewer threads are resolved or outdated.

Findings

No blocking findings.

Evidence

  • Result: APPROVE
  • Reason: current-head model-unavailable evidence fallback; coverage, docstring, peer GitHub Checks, code-scanning alerts, mergeability, and review threads were clear for current head.
  • Scope: unsupported
  • Changed files: 0
  • Model-pool outcome: exhausted
  • Head SHA: 2d4ec3b8776b4f76f3185bae3ad15786ecdf5228
  • Workflow run: 29216912110
  • Workflow attempt: 1

This fallback does not suppress failed checks, medium-or-higher code-scanning alerts, merge conflicts, unresolved reviewer threads, or failed coverage evidence; any of those conditions still publish REQUEST_CHANGES or leave the approval state unchanged.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Frontend: App.coverage.test.tsx"]
  S1 --> I1["browser runtime and bundle"]
  I1 --> R1["Review risk: Frontend: App.coverage.test.tsx"]
  R1 --> V1["frontend tests"]
Loading

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode model providers were unavailable for this same-head run, but deterministic current-head evidence is clean: coverage evidence passed, peer GitHub Checks are complete, medium-or-higher code-scanning alerts are clear, mergeability is clean, and reviewer threads are resolved or outdated.

Findings

No blocking findings.

Evidence

  • Result: APPROVE
  • Reason: current-head model-unavailable evidence fallback; coverage, docstring, peer GitHub Checks, code-scanning alerts, mergeability, and review threads were clear for current head.
  • Scope: unsupported
  • Changed files: 0
  • Model-pool outcome: exhausted
  • Head SHA: 77285025bef148c47c5e77bfafb96a63dc957a50
  • Workflow run: 29217320229
  • Workflow attempt: 1

This fallback does not suppress failed checks, medium-or-higher code-scanning alerts, merge conflicts, unresolved reviewer threads, or failed coverage evidence; any of those conditions still publish REQUEST_CHANGES or leave the approval state unchanged.

@seonghobae seonghobae enabled auto-merge (squash) July 13, 2026 02:07

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode model providers were unavailable for this same-head run, but deterministic current-head evidence is clean: coverage evidence passed, peer GitHub Checks are complete, medium-or-higher code-scanning alerts are clear, mergeability is clean, and reviewer threads are resolved or outdated.

Findings

No blocking findings.

Evidence

  • Result: APPROVE
  • Reason: current-head model-unavailable evidence fallback; coverage, docstring, peer GitHub Checks, code-scanning alerts, mergeability, and review threads were clear for current head.
  • Scope: unsupported
  • Changed files: 0
  • Model-pool outcome: exhausted
  • Head SHA: 2a3201e585923ec63af56e4e9e61f880351024e5
  • Workflow run: 29219876480
  • Workflow attempt: 1

This fallback does not suppress failed checks, medium-or-higher code-scanning alerts, merge conflicts, unresolved reviewer threads, or failed coverage evidence; any of those conditions still publish REQUEST_CHANGES or leave the approval state unchanged.

@seonghobae seonghobae merged commit 64bcb19 into main Jul 13, 2026
25 checks passed
@seonghobae seonghobae deleted the agent/stabilize-async-coverage-tests branch July 13, 2026 02:49
@github-project-automation github-project-automation Bot moved this from In Progress to Done in naruon Platform Roadmap Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant