Skip to content

feat: Add Integration Test for notification flow and Fix invalid JSON in listener/package.json - #561

Open
Fayvor22 wants to merge 2 commits into
Core-Foundry:mainfrom
Fayvor22:test
Open

feat: Add Integration Test for notification flow and Fix invalid JSON in listener/package.json #561
Fayvor22 wants to merge 2 commits into
Core-Foundry:mainfrom
Fayvor22:test

Conversation

@Fayvor22

@Fayvor22 Fayvor22 commented Jul 30, 2026

Copy link
Copy Markdown

Summary

  • Fix invalid JSON in listener/package.json (duplicate/malformed script keys) that prevented npm test from running at all
  • Remove a duplicate setTtlMs method in event-registry.ts causing a TypeScript compile error
  • Add an integration test covering a failure scenario: the event registry evicts oldest events instead of crashing/dropping new notifications when at capacity

Related

Partial progress on #404 (Add Integration Tests for Notification Flow) — unblocks the existing notification lifecycle integration/e2e tests from running in CI and adds coverage for one failed-scenario case.

Test plan

  • npm test in listener/integration.test.ts passes (2/2)
  • Note: a broader pre-existing compilation issue (duplicated code blocks in files like events-server.ts, config.ts) still breaks ~35 other test suites; out of scope for this PR, flagged separately

Closes #404

@drips-wave

drips-wave Bot commented Jul 30, 2026

Copy link
Copy Markdown

@Fayvor22 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Integration Tests for Notification Flow

1 participant