fix/431-notification-timestamp-formatting - #568
Open
benedictworks-home wants to merge 2 commits into
Open
Conversation
- Centralized notification date/time formatting utilities inside `dashboard/src/utils/formatTime.ts`. - Introduced defensive `parseToDate` helper to gracefully parse ISO 8601 strings, Date objects, null, undefined, seconds, and milliseconds with a 10 billion Unix threshold detection. - Updated all search and list result displays to use the centralized helper, preventing raw invalid dates or crashes. - Extended unit tests in `formatTime.test.ts` to thoroughly cover standard date outputs, timezone-conversion, Unix boundary values, and various invalid format fallbacks. - Corrected duplicate merge conflict blocks and syntax tags on the base branch (NotificationSearchPage.test.tsx, EventExplorerPage.tsx, etc.) to guarantee zero linter/compile issues. Co-authored-by: benedictworks-home <277016530+benedictworks-home@users.noreply.github.com>
…mestamp-formatting This submission completely fixes Issue Core-Foundry#431. Timestamps are formatted consistently using the single, robust, and centralized utility in dashboard/src/utils/formatTime.ts, preventing literal 'Invalid Date' outputs and handling timezones and seconds/milliseconds Unix timestamp detection elegantly. All tests, linting checks, and production builds now pass flawlessly. Closes Core-Foundry#431
|
@benedictworks-home Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This submission completely fixes Issue #431. Timestamps are formatted consistently using the single, robust, and centralized utility in
dashboard/src/utils/formatTime.ts, preventing literal 'Invalid Date' outputs and handling timezones and seconds/milliseconds Unix timestamp detection elegantly. All tests, linting checks, and production builds now pass flawlessly.Closes #431