-
Notifications
You must be signed in to change notification settings - Fork 14
Coverage nexp masks #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
martinkilbinger
wants to merge
29
commits into
develop
Choose a base branch
from
coverage
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Coverage nexp masks #797
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
668e05d
removed tmp files
martinkilbinger de045f5
Merge branch 'p9' of github.com:martinkilbinger/shapepipe-1 into p9
martinkilbinger 38c5819
Moved get_ccds script to pipeline runner and library script
martinkilbinger d6144ad
class to download eposure headers (for coverage)
martinkilbinger bc43799
coverage mask: scripts and plotter; using cs_util
martinkilbinger 487166c
coverage code: added Mike Hudson as co-author
martinkilbinger d0d5488
documentation (in pipeline_canfar.md) on coverage mask scripts and cl…
martinkilbinger bc8b006
Merge remote-tracking branch 'origin/coverage' into coverage
martinkilbinger f4d00d0
CCD PSF Handler: Added version for v1.3
271ff40
fixed coverage plots
martinkilbinger 7f99f5a
header downloads (coverage): account for existing downloads
martinkilbinger 77fe037
Merge branch 'coverage' of github.com:martinkilbinger/shapepipe-1 int…
martinkilbinger be10deb
Merge remote-tracking branch 'upstream/develop' into coverage
martinkilbinger 728f413
Merge branch 'develop' into coverage
martinkilbinger e10111b
canfar-changes
martinkilbinger ac94c16
Merge remote-tracking branch 'origin/coverage' into coverage
martinkilbinger 6d10285
Merge remote-tracking branch 'origin/develop' into coverage
cailmdaley fd61120
PR: remove non-functioning coverage pipeline function
martinkilbinger fc37cbf
PR: coverage_map_builder; moved import into try block
martinkilbinger afcbae6
PR: field_corners_extractor.py; fixed exp number extraction
martinkilbinger 96cc4f5
PR: added comment
martinkilbinger 5215788
PR: added comment
martinkilbinger bbe53c5
refactor: consolidate field_corners_extractor helpers; fix regex
cailmdaley 134a79f
refactor: coverage_map_builder cleanup
cailmdaley 9a574e9
docs: declare verbose and annotate survey-specific defaults
cailmdaley 517acff
Merge branch 'develop' into coverage
cailmdaley dfeff38
chore: uv lock — register healsparse + skyproj as shapepipe deps
cailmdaley 8b9387b
fix: coverage console scripts handle -h; drop dead entry point
cailmdaley 37d5af8
test: unit + property tests for the coverage-mask feature
cailmdaley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| #!/bin/bash | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No |
||
|
|
||
| # Configuration variables | ||
|
|
||
| ## Catalogue versions | ||
| VERSIONS=("v1.3" "v1.4" "v1.5" "v1.6") | ||
|
|
||
| ## Output directory of plots | ||
| OUTPUT_DIR="coverage_map_plots" | ||
|
|
||
| # healsparse resolution. nside=131072 gives ~0.1" per pixel, chosen to | ||
| # match the UNIONS bit-mask resolution so coverage and mask align pixel- | ||
| # wise. CoverageMapBuilder defaults to nside=2048 for lighter-weight | ||
| # offline use; override here for the production build. | ||
| BUILD_NSIDE=131072 | ||
| BUILD_CHANNELS=128 | ||
|
|
||
| # Common parameters | ||
| VERBOSE="-v" | ||
|
|
||
| ## Colorbar | ||
| PLOT_COLORBAR="-C" | ||
| PLOT_MIN=1 | ||
| PLOT_MAX=5 | ||
|
|
||
| # Plot parameters | ||
| ## SGC region | ||
| SGC_RA_MIN=-20 | ||
| SGC_RA_MAX=45 | ||
| SGC_DEC_MIN=18 | ||
| SGC_DEC_MAX=40 | ||
|
|
||
| ## NGC region | ||
| NGC_RA_MIN=110 | ||
| NGC_RA_MAX=270 | ||
| NGC_DEC_MIN=28 | ||
| NGC_DEC_MAX=90 | ||
|
|
||
| # Create output directory if it doesn't exist | ||
| mkdir -p "${OUTPUT_DIR}" | ||
|
|
||
| # Loop over versions | ||
| for VERSION in "${VERSIONS[@]}"; do | ||
| echo "Processing ${VERSION}..." | ||
|
|
||
| # Define file paths | ||
| INPUT_EXP="exp_ra_dec_${VERSION}.txt" | ||
| COVERAGE_MAP="coverage_${VERSION}.x.hsp" | ||
|
|
||
| # Build coverage map | ||
| echo " Building coverage map from ${INPUT_EXP}..." | ||
| CMD="build_coverage_map -i ${INPUT_EXP} -o ${COVERAGE_MAP} -c ${BUILD_CHANNELS} -n ${BUILD_NSIDE} ${VERBOSE}" | ||
| echo "$CMD" | ||
| $CMD | ||
|
|
||
| # Plot SGC region | ||
| echo " Plotting SGC region..." | ||
| CMD="plot_coverage_map -i ${COVERAGE_MAP} -o ${OUTPUT_DIR}/coverage_${VERSION}_SGC.png ${VERBOSE} ${PLOT_COLORBAR} -R ${SGC_RA_MIN} -r ${SGC_RA_MAX} -D ${SGC_DEC_MIN} -d ${SGC_DEC_MAX} -m ${PLOT_MIN} -M ${PLOT_MAX}" | ||
| echo "$CMD" | ||
| $CMD | ||
|
|
||
| # Plot NGC region | ||
| echo " Plotting NGC region..." | ||
| CMD="plot_coverage_map -i ${COVERAGE_MAP} -o ${OUTPUT_DIR}/coverage_${VERSION}_NGC.png ${VERBOSE} ${PLOT_COLORBAR} -R ${NGC_RA_MIN} -r ${NGC_RA_MAX} -D ${NGC_DEC_MIN} -d ${NGC_DEC_MAX} -m ${PLOT_MIN} -M ${PLOT_MAX}" | ||
| echo "$CMD" | ||
| $CMD | ||
|
|
||
| echo " Done with ${VERSION}" | ||
| echo | ||
| done | ||
|
|
||
| echo "All versions processed successfully!" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-i exp_ra_dec_v1.6, but theextract_field_cornersstep above is run without-o, so it writes the defaultexp_ra_dec.txt— this filename is never produced, and the example throwsFileNotFoundErrorif followed verbatim. Align the two.