Migrate remark-code-blocks to TypeScript with globalThis promise caching#3
Closed
tbjers wants to merge 6 commits into
Closed
Migrate remark-code-blocks to TypeScript with globalThis promise caching#3tbjers wants to merge 6 commits into
tbjers wants to merge 6 commits into
Conversation
Converts the JSDoc-annotated .js plugin to native TypeScript and fixes repeated Shiki initializer warnings during build by caching the createHighlighter() Promise on globalThis instead of the resolved value, eliminating the race where concurrent .svx processors each triggered a new instantiation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying coveragetracker-dev with
|
| Latest commit: |
9f6045a
|
| Status: | 🚫 Build failed. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Renames to svelte.config.ts, removes the JSDoc @type annotation, and adds native TypeScript types for Config and PreprocessorGroup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remark-code-blocks.js(JSDoc +// @ts-check) to native TypeScript (remark-code-blocks.ts)createHighlighter()Promise onglobalThisinstead of the resolvedHighlighter— eliminating the race where all concurrent.svxprocessors saw an uninitialized singleton and each triggered a new instantiationsvelte.config.jsto use the.tsextension (required because Node's ESM resolver does not fall back from.jsto.ts; Vite handles.tsimports from config files natively)Test plan
pnpm check— 0 errors, 0 warningspnpm build— verify no repeated Shiki initialization warnings in outputpnpm dev— verify hot-reload does not re-initialize the highlighter on subsequent module evaluations🤖 Generated with Claude Code