fix: surface living ui persistence failures

[BharadwajKanneveti]

What

• Updated _save_projects() to re-raise persistence errors instead of silently swallowing them.
• Added caller-level handling for project save failures based on the execution context.
• Added warning handling for running projects when state persistence fails, while allowing the active process to continue.

Why

_save_projects() previously caught all write failures internally and only logged them. This caused project state changes to be silently lost when persistence failed due to issues like permission errors or disk failures.

As a result, projects could disappear after restart, auto-launch state could be lost, and task links could become unavailable.

This change ensures persistence failures are visible and handled appropriately instead of being silently ignored.

Closes #214

[BharadwajKanneveti]

Hi @AlanAAG I have raised the PR please check and let me know if you find any issue

[AlanAAG]

Hi @AlanAAG I have raised the PR please check and let me know if you find any issue

Hey @BharadwajKanneveti Thank you for the contribution will review promptly! Will let you know over here.

[AlanAAG]

@BharadwajKanneveti hey some comments after review

Correct core fix — _save_projects() re-raises, all 17 real callsites are wrapped and correctly triaged into the 3 buckets, _load_projects() correctly untouched. ruff clean.

1. Two callsites outside this file aren't wrapped

app/ui_layer/settings/profile_bundle.py:939 (_register_living_ui_via_manager) and :974 (_wipe_living_ui_state) call _save_projects() unwrapped. Caught by an outer except Exception in import_profile() so nothing crashes, but a Living UI save failure now reports the entire profile-bundle import as "Import failed", even if skills/MCP/personality already applied successfully. Fix: wrap both in try/except, log-and-continue bucket.

2. The warning key never reaches a user — this is the one that matters

Traced every caller of launch_and_verify() / _launch_servers_only() and confirmed by test:

• launch_project() (browser adapter's entry point) collapses the result to a bare bool.
• living_ui_actions.py::living_ui_notify_ready() and app/living_ui/actions.py::restart_living_ui() both rebuild their own success dict without checking result.get("warning").

Result: the warning: state_not_persisted key computed in the 3 critical paths is dead code — no user, toast, or agent message will ever see it. Right now this fix makes failures visible in server logs only; it doesn't yet deliver the user-visible warning the issue requires ("the user must know the state won't survive a restart"). Fix: have the 3 callers of launch_and_verify()/_launch_servers_only() check for and relay warning up through to their response.

[zfoong]

@BharadwajKanneveti @AlanAAG The warning does not have to surface to the user, toast, or agent message for now. We are revamping the LivingUI system, so as long as the warning is surface to service log, then it should be fine.

[BharadwajKanneveti]

Thanks for the clarification!

@AlanAAG @zfoong
Just to confirm before I update the PR: based on your comment, should I only implement the profile_bundle.py changes and leave the warning propagation (launch_project(), living_ui_notify_ready(), and restart_living_ui()) unchanged, since logging the warning is sufficient for now?

[zfoong]

Thanks for the clarification!

@AlanAAG @zfoong Just to confirm before I update the PR: based on your comment, should I only implement the profile_bundle.py changes and leave the warning propagation (launch_project(), living_ui_notify_ready(), and restart_living_ui()) unchanged, since logging the warning is sufficient for now?

Yes I think we can go with that for now. Thanks! Another PR is also making big changes to Living UI, so let's leave it as it is.

[BharadwajKanneveti]

Hi @zfoong I have made the changes please check and let me know if you find any issue.