Skip to content

fix(analytics): push the gtag arguments object, not a rest array #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CropWatchDevelopment merged 1 commit into from
Jun 20, 2026
Merged

fix(analytics): push the gtag arguments object, not a rest array #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/lib/analytics/gtag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ type GtagArgs = unknown[];

declare global {
interface Window {
dataLayer?: GtagArgs[];
dataLayer?: unknown[];
gtag?: (...args: GtagArgs) => void;
}
}
Expand All @@ -35,10 +35,13 @@ export function initAnalytics(measurementId: string, options: { userId?: string
document.head.appendChild(script);

window.dataLayer = window.dataLayer ?? [];
// gtag forwards its raw argument list onto the data layer; gtag.js reads each
// entry by index/length, so pushing the rest array behaves like `arguments`.
window.gtag = function gtag(...args: GtagArgs) {
window.dataLayer!.push(args);
// gtag.js ONLY processes data-layer entries that are the live `arguments`
// object — a real array (e.g. from rest params) is silently ignored, so the
// events queue but never send. Push `arguments`, exactly like the canonical
// snippet.
window.gtag = function gtag() {
// eslint-disable-next-line prefer-rest-params
window.dataLayer!.push(arguments);
};
window.gtag('js', new Date());
window.gtag('config', measurementId, {
Expand Down