Fix lint on main (graph_layout.py + dimensionality.py)#197
Merged
Conversation
The `lint` CI job (black + ruff + mypy) has been red on main: PRs #190/#194 merged embedding/graph_layout.py and PaCMAP code that fail black/ruff/mypy, and the failure was masked on downstream PRs because black exits first. - graph_layout.py: black reformat; sort imports (I001); rename adjacency matrix A -> adj (N806); zip(..., strict=True) (B905); type: ignore the sklearn imports (import-untyped), matching the existing umap/pacmap pattern. - dimensionality.py: rename X -> normalized_vectors (N806); type: ignore the sklearn.preprocessing import. Behavior-neutral. black + ruff + mypy now all pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
lintCI job (black + ruff + mypy) has been red onmain.#190/#194mergedembedding/graph_layout.pyand PaCMAP code that fail black/ruff/mypy; the failure was masked on downstream PRs because black exits before ruff/mypy run. This is why open PRs #187 and #189 show a redlintcheck — they inherit main's breakage.What
A→adj(N806);zip(..., strict=True)(B905);# type: ignore[import-untyped]on the sklearn imports (matches the existingumap/pacmappattern).X→normalized_vectors(N806); type-ignore thesklearn.preprocessingimport.Behavior-neutral.
black --check+ruff check+mypyall pass locally;sfdp_layoutsmoke-tested on a real 6×4 matrix.🤖 Generated with Claude Code