Review-cleanup sweep: vendor d3, PaCMAP relabel, footer, data tables, markers, discussions dark mode#150
Merged
Merged
Conversation
…les, marker size, discussions dark mode
Stacks on feat/dark-mode-toggle. Additive dataviz/artifact-design cleanup;
light and dark themes both preserved. Templates + regenerated pages (477/477).
- R1 Vendor d3 locally (drop d3js.org CDN): add pages/d3.v7.min.js (v7.9.0,
byte-identical to the shared copy); point umap.html, graph.html, and
trait.html script src at {{ root }}d3.v7.min.js. No CDN refs remain.
- R2 PaCMAP relabel: index.html embedding card body "Interactive UMAP" ->
"Interactive PaCMAP" (umap.html header already said PaCMAP).
- R4 Footer: fix base.html stale footer (4 -> 5 Mechs incl. ProteinTraitsMech;
METPO w3id -> BioPortal) to match index.html; render current Mech (TraitMech)
as plain <span> text in both base.html and index.html (no self-link).
- R5 Data-table fallback: keyboard-reachable <details> "View data as table" +
Download CSV below the plot on umap.html and graph.html, built from the same
points the scatter renders (label, CURIE, category, x, y), theme-tokenized.
- R6 Marker size: scatter radius r=4 -> r=5 in umap.html and graph.html.
- Dark + toggle for app/discussions/index.html: vendored theme-toggle.js,
dark palette (OS default + data-theme override), reduced-motion block.
Preserves the HREF_BY_ID click-through fix on the base branch.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
11 tasks
Contributor
Author
|
Reviewed the PR's own diff (base Clean — no blocking issues. All claims verified:
Minor, non-blocking (out of stated scope): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on
feat/dark-mode-toggle(do not merge before that branch). Additive dataviz/artifact-design review cleanup — light and dark themes both preserved. Templates edited + pages regenerated viajust gen-pages(477/477 traits).Changes
pages/d3.v7.min.js(v7.9.0, byte-identical to the shared CommunityMech copy). Pointedumap.html,graph.html, andtrait.htmlscriptsrcat{{ root }}d3.v7.min.js. Nod3js.orgrefs remain (355 trait/scatter pages now load the local file).index.htmlembedding card body "Interactive UMAP" → "Interactive PaCMAP" (umap.htmlheader already said PaCMAP; data keysumap_x/umap_yand file names left unchanged).base.html's stale footer (4 → 5 Mechs incl. ProteinTraitsMech; METPOw3id→ BioPortal) to matchindex.html; rendered the current Mech (TraitMech) as plain<span>text (no self-link) in bothbase.htmlandindex.html.<details>"View data as table" + Download-CSV link directly below the plot onumap.htmlandgraph.html, built from the same points the scatter renders (label, CURIE, category, x, y), theme-tokenized.r=4→r=5inumap.htmlandgraph.html.app/discussions/index.htmlgets a vendoredtheme-toggle.js, a dark palette (OS default +data-themeoverride), and a reduced-motion block.Preserves the
HREF_BY_IDclick-through fix already on the base branch.Verification
grep d3js.orgoversrc/+pages/: 0 code refs remain.<span>everywhere).<details>/table +r=5present on both scatter pages.🤖 Generated with Claude Code