perf(walletapi): reduce sync polling interval from 5s to 3s#28
Open
moralpriest wants to merge 1 commit into
Open
perf(walletapi): reduce sync polling interval from 5s to 3s#28moralpriest wants to merge 1 commit into
moralpriest wants to merge 1 commit into
Conversation
The sync loop sleep between iterations was 5s, but each iteration also blocks on RPC calls. With DERO block time of 18s, a 5s sleep results in ~3 polls per block. Reducing to 3s gives ~6 polls per block, improving responsiveness without adding significant load since RPC calls are sub-second. The timeout variable is shared with Keep_Connectivity, which also benefits from faster liveness checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the timeout variable from 5s to 3s. This variable controls the sync loop sleep between iterations and the Keep_Connectivity ping interval.
Problem
With DERO block time of 18s, a 5s sleep means ~3 polls per block. This can cause the wallet to miss new blocks or appear stale on fast connections.
Changes
var timeout = 5 * time.Secondtovar timeout = 3 * time.SecondNotes