Skip to content

Draft: Fix memory problem with alt hla#87

Open
vinjana wants to merge 4 commits into
ReleaseBranch_1.2.73-2from
fix-memory-problem-with-alt-hla
Open

Draft: Fix memory problem with alt hla#87
vinjana wants to merge 4 commits into
ReleaseBranch_1.2.73-2from
fix-memory-problem-with-alt-hla

Conversation

@vinjana

@vinjana vinjana commented May 9, 2023

Copy link
Copy Markdown
Member

Looks like a lot, but most changes are only refactorings (mostly groovification, layout, and some other small things).

  • minor: Added bwaPostAltJsK8Options to allow setting opt K8 options for bwa-postalt.js
  • minor: Added SAMPESORT_MEMSIZE to allow reducing memory for SAM sorting. Default: ~2 GiB.
  • minor: Upgrade from COWorkflows 1.2.76 to COWorkflowsBasePlugin 1.4.2.
    • minor: Old FLAG_USE_EXISTING_PAIRED_BAMS was renamed to FLAG_USE_ONLY_EXISTING_PAIRED_BAMS
    • minor: Removed FLAG_RUN_SLIM_WORKFLOW. Corresponding code is unused for years.
  • patch: Little refactorings and groovification of old Java code

…n ALT processing.

Removed FLAG_RUN_SLIM_WORKFLOW that is unusable for years.
Renamed FLAG_USE_EXISTING_PAIRED_BAMS to FLAG_USE_ONLY_EXISTING_PAIRED_BAMS
@vinjana vinjana requested a review from NagaComBio May 9, 2023 07:15
@vinjana

vinjana commented May 9, 2023

Copy link
Copy Markdown
Member Author

Sorry, the COWorkflowsBasePlugin 1.4.2 bump has to be rolled back. I somehow get compilation problems now, and have no clue why, because the original changes are actually really old.

@vinjana vinjana changed the title Fix memory problem with alt hla Draft: Fix memory problem with alt hla May 9, 2023
…ed for backwards compatibility.

* Added Claude configs.
* Added first in-repo documentation.

Signed-off-by: Philip R. Kensche <p.kensche@dkfz-heidelberg.de>
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ee5645f1-cd0b-4619-acd5-7dd798bc8581

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-memory-problem-with-alt-hla

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Philip R. Kensche <p.kensche@dkfz-heidelberg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant