Fix builds on machines other than the original dev's#4
Open
s474 wants to merge 1 commit into
Open
Conversation
…n the original developer's
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The committed project.pbxproj contained a number of paths hardcoded to the original developer's machine (/Users/tdknox/...) that prevented the project from building anywhere else. This PR fixes all of them.
Changes to project.pbxproj:
• Removed incorrect path = C64IDE from the root navigator group (files are at SOURCE_ROOT, not SOURCE_ROOT/C64IDE/)
• Fixed Templates folder reference path (removed spurious C64IDE/ prefix)
• Fixed three source files (AsmToDataDialog.swift, AsmToDataGenerator.swift, NSTextField+Shake.swift) that had absolute paths to the original developer's machine
• Fixed C64ROMSymbols.swift which had a SOURCE_ROOT-relative path with C64IDE/ prefix
• Replaced INFOPLIST_FILE = C64IDE/Info.plist (file does not exist) with GENERATE_INFOPLIST_FILE = YES
• Fixed LIBRARY_SEARCH_PATHS and SWIFT_OBJC_BRIDGING_HEADER (removed C64IDE/ prefix)
• Fixed VC64Bridge.mm per-file compiler flags: replaced hardcoded /Users/tdknox/Source/git/virtualc64/... include paths with $(SRCROOT)/../virtualc64/...
• Removed BasicStubGenerator.swift reference (file is missing from the repository)
Changes to AppDelegate+ProjectActions.swift:
• Added @mainactor to handleCharsetSendToMapEditor to fix a Swift concurrency error (calling a @MainActor-isolated method from a non-isolated context)
Changes to README.md:
• Added build instructions explaining the VirtualC64 dependency: clone as a sibling repo, build static libraries with CMake, copy into VirtualC64/lib/