Skip to content

Fix README shared-library link flag (-ldd_trace_cpp -> -ldd-trace-cpp)#344

Open
spottsdd wants to merge 1 commit into
mainfrom
feature/readme-shared-lib-name
Open

Fix README shared-library link flag (-ldd_trace_cpp -> -ldd-trace-cpp)#344
spottsdd wants to merge 1 commit into
mainfrom
feature/readme-shared-lib-name

Conversation

@spottsdd

Copy link
Copy Markdown
Collaborator

Summary

  • The Dynamic Linking section of the README instructs linking with -ldd_trace_cpp (underscore), but CMakeLists.txt sets OUTPUT_NAME "dd-trace-cpp" (hyphen) for both the shared and static library targets.
  • The installed file is actually libdd-trace-cpp.so/libdd-trace-cpp.a, so following the README's -ldd_trace_cpp instruction as written fails at link time (ld: cannot find -ldd_trace_cpp) / find_library can't locate it under that name.
  • Updated the two link-flag mentions and the example command to use -ldd-trace-cpp.

Test plan

  • Docs-only change; verified the corrected flag matches OUTPUT_NAME "dd-trace-cpp" in CMakeLists.txt and manually confirmed cmake --install produces libdd-trace-cpp.so on a fresh build.

Recreates #340 from a branch on this repository (instead of a fork) at @xlamorlette-datadog's request, so CI runs correctly.

Made with Cursor

…cpp)

CMakeLists.txt sets OUTPUT_NAME "dd-trace-cpp" for the shared and static
targets, so the installed file is libdd-trace-cpp.so/.a. The README's
dynamic linking section still referenced the old -ldd_trace_cpp flag,
which doesn't match any installed library name and fails at link time.

Co-authored-by: Cursor <cursoragent@cursor.com>
@pr-commenter

pr-commenter Bot commented Jul 24, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-24 13:34:37

Comparing candidate commit d11624c in PR branch feature/readme-shared-lib-name with baseline commit 24f765c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@datadog-datadog-prod-us1

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 91.75% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d11624c | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants