Fix README shared-library link flag (-ldd_trace_cpp -> -ldd-trace-cpp)#344
Fix README shared-library link flag (-ldd_trace_cpp -> -ldd-trace-cpp)#344spottsdd wants to merge 1 commit into
Conversation
…cpp) CMakeLists.txt sets OUTPUT_NAME "dd-trace-cpp" for the shared and static targets, so the installed file is libdd-trace-cpp.so/.a. The README's dynamic linking section still referenced the old -ldd_trace_cpp flag, which doesn't match any installed library name and fails at link time. Co-authored-by: Cursor <cursoragent@cursor.com>
BenchmarksBenchmark execution time: 2026-07-24 13:34:37 Comparing candidate commit d11624c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.
|
|
🎯 Code Coverage (details) 🔗 Commit SHA: d11624c | Docs | Datadog PR Page | Give us feedback! |
Summary
-ldd_trace_cpp(underscore), butCMakeLists.txtsetsOUTPUT_NAME "dd-trace-cpp"(hyphen) for both the shared and static library targets.libdd-trace-cpp.so/libdd-trace-cpp.a, so following the README's-ldd_trace_cppinstruction as written fails at link time (ld: cannot find -ldd_trace_cpp) /find_librarycan't locate it under that name.-ldd-trace-cpp.Test plan
OUTPUT_NAME "dd-trace-cpp"inCMakeLists.txtand manually confirmedcmake --installproduceslibdd-trace-cpp.soon a fresh build.Recreates #340 from a branch on this repository (instead of a fork) at @xlamorlette-datadog's request, so CI runs correctly.
Made with Cursor