Fix cmake install missing http_endpoint_calculation_mode.h#345
Conversation
tracer_config.h (a public header) includes http_endpoint_calculation_mode.h, but it was missing from the public_headers FILE_SET in CMakeLists.txt, so cmake --install never copies it. Any consumer building from source and installing to a prefix (per the README's manual build instructions) gets a fatal "http_endpoint_calculation_mode.h: No such file or directory" error compiling anything that includes tracer_config.h/tracer.h. Co-authored-by: Cursor <cursoragent@cursor.com>
BenchmarksBenchmark execution time: 2026-07-24 13:38:14 Comparing candidate commit f634ffe in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 7 metrics, 0 unstable metrics.
|
|
🎯 Code Coverage (details) 🔗 Commit SHA: f634ffe | Docs | Datadog PR Page | Give us feedback! |
Summary
tracer_config.h(a public header) includeshttp_endpoint_calculation_mode.h, but that file is missing from thepublic_headersFILE_SETlist inCMakeLists.txt.cmake --installnever copieshttp_endpoint_calculation_mode.hto the install prefix'sinclude/datadog/directory, even though the file exists in the source tree.tracer.h/tracer_config.h:FILE_SETlist, alphabetically placed next to the otherhttp_*header.Recreated from #341, which was opened from a fork; this one is opened from a branch on the main repo instead.
Test plan
FILESlist inCMakeLists.txtagainst the actual contents ofinclude/datadog/in the source tree — this was the only header present in the tree but absent from the list.cmake -B build . && cmake --build build -j && cmake --install build, then compiling a file that includes<datadog/tracer.h>failed with the error above.Made with Cursor