Add anymaputils#740
Open
bsofjan wants to merge 2 commits into
Open
Conversation
CJA18
reviewed
Jul 7, 2026
CJA18
left a comment
CJA18
left a comment
There was a problem hiding this comment.
This PR looks good to me - only consideration would be to switch the namespace names to .util.anymap.XXX to indicate that it is a util function (we use this naming convention on my client), but this is only if it makes sense in the context of the wider codebase (I haven't checked I will leave that to you @bsofjan)
Author
|
Addressed comments made through new commit. |
Author
|
Hey @CJA18, thank you for your suggestions on naming the namespace! I am following the names given in the Anycache project proposal, although I am open for discussions to rename it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add anymaputils