fix: read_parquet on embed:// bundle entries (GetLastModifiedTime)#103
Merged
Conversation
DuckDB's parquet reader calls GetLastModifiedTime; the base class throws
Not Implemented, so read_parquet('embed://...') failed for bundled data
while read_csv worked. Return the epoch — bundle entries are immutable
and a stable mtime preserves SOURCE_DATE_EPOCH reproducibility.
Closes #101
jrosskopf
added a commit
that referenced
this pull request
Jul 13, 2026
…ackaging) All real recordings via VHS with committed tapes and demo project trees: - flapi-demo-agent.gif: Claude Code answering questions through flAPI MCP tools (Basic auth, per-tool RBAC) — requires fix #100 - flapi-demo-bigquery.gif: agent on top of BigQuery public data with typed prepared-statement params; the model never writes SQL - flapi-demo-pack.gif: flapi pack single-binary deploy, served from /tmp - assets/README.md documents reproduction, and why SAP/SharePoint demos were not recorded (no live backend / no connector) rather than staged Recording these surfaced and fixed two launch-blocking bugs: #100 (PR #102) and #101 (PR #103).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_parquet('embed://data/x.parquet')on a packed binary failed withNot implemented Error: embed: GetLastModifiedTime is not implemented!— the parquet reader calls a FileSystem virtual thatEmbeddedFileSystemdidn't override (read_csv doesn't, which is why the documented case worked).SOURCE_DATE_EPOCHreproducibility intact.Test plan
Closes #101
🤖 Generated with Claude Code
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.