Truncate long names instead of running off screen - #389
Open
johnmaguire wants to merge 2 commits into
Open
Conversation
A cert name on the tunnels list and a group name on the firewall rule screen were both laid out in a Row with no width constraint, so a long value overlapped the row's chevron and ran past the right edge. Both now ellipsize at the edge. Measured with the bundled Inter metrics at 320/360/390dp: a 53 char cert name overflowed by 73-143px, and a 45 char group name by 20-60px at 360dp and below.
johnmaguire
marked this pull request as ready for review
July 24, 2026 21:42
A truncated group name hides the part that distinguishes it: rules scoped to engineering-production-us-east-database-servers and engineering-production-us-west-database-servers ellipsize to the same string. The chip now wraps to at most three lines, keeping ellipsis only as a backstop past that. Setting overflow without maxLines is what pinned the label to one line, so the wrap needs both. Names with no whitespace or hyphen to break on still fit: Flutter breaks mid-token rather than overflowing the chip.
Member
Author
|
Updated to wrap group names |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long names could run past the right edge of the screen. Two places lay a
name out in a
Rowwith no width constraint, so the text overlapped therow's chevron and continued off screen:
site_tunnels_screen.dart)pill_chip.dart)Both now ellipsize at the edge.
Screenshots
360dp wide, the common Android width. The red bar and hazard stripes are
Flutter's debug overflow indicator.
Active Tunnels
Firewall Rule groups