Skip to content

feat(commissions): build milestones tab inside commission detail page (#402) - #457

Merged
ayshadogo merged 2 commits into
Dfunder:mainfrom
RUKAYAT-CODER:feat/wave-issue-402-milestone-tab
Jul 29, 2026
Merged

feat(commissions): build milestones tab inside commission detail page (#402)#457
ayshadogo merged 2 commits into
Dfunder:mainfrom
RUKAYAT-CODER:feat/wave-issue-402-milestone-tab

Conversation

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Summary

Adds a Milestones tab to app/commissions/[id]/page.tsx per the spec:

  • Progress bar: shows approved USDC / budget USDC plus a labelled percentage and an over-budget warning if the proposed total exceeds the budget.
  • Milestone list: title, description, amount, due date, Approved/Pending badge, and a client-only Approve button that flips a milestone's status.
  • Add milestone (artist-only): title, description, due date, amount fields with inline validation. Required fields, positive amount, and a guard that the sum of all milestones cannot exceed the commission budget USDC.
  • Reuses the existing detail-page pieces (app/[id]/page.tsx Overview / action bar / role toggle) so this single PR also lands parts of Build commission detail page #399's surface.

Notes

Closes #402

…Dfunder#402)

Adds a 'Milestones' tab to the commission detail page (app/commissions/[id]/page.tsx). On the tab:
- Progress bar showing approved USDC / total USDC, with a roll-up label and percentage.
- Milestone list with title, description, amount, due date, and a status badge (Approved/Pending). Client role can press Approve to flip a milestone.
- Artist role sees an Add milestone form with title, description, amount, due-date inputs and inline validation: required fields, positive amount, and a guard that the sum of all milestones cannot exceed the commission budget USDC (rejected with an inline error before submission).
- Wrapped in <main id='main-content'>.

Same page also covers the Dfunder#399 detail spec (status header + budget/deadline info grid + description/attachments + status-aware action bar PENDING/IN_PROGRESS/SUBMITTED/COMPLETED with the correct Accept / Reject / Submit Work / Request Revision / Approve / Leave Review buttons per role). The mock role toggle in the header lets reviewers preview both client and artist views in two clicks.

Closes Dfunder#402
@drips-wave

drips-wave Bot commented Jul 28, 2026

Copy link
Copy Markdown

@RUKAYAT-CODER Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@ayshadogo ayshadogo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayshadogo
ayshadogo merged commit 441a29f into Dfunder:main Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build milestone management UI

2 participants