fix: admin RBAC, emergency fake data, search race condition, push not… - #818
Merged
llinsss merged 1 commit intoJul 29, 2026
Conversation
|
@Hahfyeex Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
llinsss
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses four independent frontend bugs across security, data integrity, UX correctness, and feature completeness.
#762 — Admin pages have no role-based access control
role: UserRolefield to theUserinterface inAuthContext.tsxProtectedRoutewith arequireAdminprop that redirects non-admins to/dashboardreports.tsx,security.tsx,sms.tsx) with<ProtectedRoute requireAdmin>Header.tsxbehind auser?.role === 'admin'checkCloses #762
#757 — getPetEmergencyInfo silently returns fake hardcoded contacts on 404
getMockEmergencyInfoentirely frompetAPI.tsgetPetEmergencyInfonow returnsnullon 404 instead of fabricated datascan/[id].tsxto render a clear "No Emergency Info Set Up" notice whenemergencyisnulland no inline contact exists — a stranger scanning a tag gets an honest state rather than fictional phone numbersCloses #757
#763 — Race condition in search: stale responses overwrite fresh results
AbortControllerref tosearch.tsxhandleSearchcall cancels the previous in-flight request before issuing a new oneAbortErrors are caught and ignoredsetIsLoading(false)only fires if the completing request is still the active oneCloses #763
#755 — Push notifications are fully stubbed out
firebase.ts(was fully commented out with a hard-codedreturn null)getFirebaseMessaging()now initialises the Firebase app and returns aMessaginginstance, guarded by SSR, browser support, and missing-env-var checksfirebasetopackage.jsondependencies (was the root cause of the original stub)usePushNotificationsandnotificationServicealready wire upregisterDeviceToken/removeDeviceTokencorrectly and will work once the package is installedCloses #755