fix: check effective uid instead of username for root - #13
Merged
Conversation
Comparing currentUser.Username against "root" misses uid-0 accounts that are not literally named root. Replace CheckCurrentUser with CheckRoot, which uses os.Geteuid() == 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The root-privilege check compared
currentUser.Usernameagainst the literal string"root", which misses uid-0 accounts that are not namedroot. Switched to an effective-uid check.Changes
utils.CheckCurrentUser(wantedUser string)withutils.CheckRoot(), which returns an error unlessos.Geteuid() == 0.cmd/main.go.os/userimport.Testing
go build ./...✅go vet ./...✅