fix(ci): resolve the deploy ref with git - #37
Merged
Conversation
The rollback still failed after fetch-depth: 0, with 'a branch or tag with the name 026f727 could not be found'. actions/checkout's ref input takes a branch, a tag, or a full 40-character SHA — an abbreviated one is not accepted, and abbreviated is how commits are actually quoted. Checks out the default branch with full history and then lets git move to the requested ref, which accepts branches, tags, and SHAs of any length.
Contributor
Deploying hookdrop-frontend with
|
| Latest commit: |
89ad234
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e7bbc88e.hookdrop-frontend.pages.dev |
| Branch Preview URL: | https://fix-deploy-resolve-ref.hookdrop-frontend.pages.dev |
Contributor
Deploying hookdrop with
|
| Latest commit: |
89ad234
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ab660538.hookdrop.pages.dev |
| Branch Preview URL: | https://fix-deploy-resolve-ref.hookdrop.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second iteration on the rollback path, both found by running it rather than trusting it.
fetch-depth: 0was necessary but not sufficient —actions/checkout'srefaccepts a branch, a tag, or a full 40-character SHA, and a short SHA fails witha branch or tag with the name '026f727' could not be found. Short SHAs are how commits get quoted in practice.Now checks out the default branch with full history and lets
git checkoutmove to the requested ref, which handles branches, tags and SHAs of any length.Production untouched through both failed attempts — checkout is the first step, long before anything on the server is involved.