Regression tests: cursor pagination, quest-list caching, wizard/wallet a11y, claim flow - #2128
Merged
RUKAYAT-CODER merged 1 commit intoJul 29, 2026
Conversation
|
@devwums Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…d/wallet a11y, and claim flow - BackEnd/src/modules/quests/quests-pagination.spec.ts: verifies keyset cursor pagination sets/omits nextCursor correctly and filters by createdAt rather than an offset - BackEnd/src/modules/quests/quests-cache.spec.ts: verifies GET /quests results are served from Redis cache on hit and populate the cache on miss - FrontEnd/my-app/tests/a11y/quest-wizard-wallet-modal.test.ts: axe-core coverage for the quest creation wizard and wallet connect modal - FrontEnd/my-app/lib/hooks/useClaim.test.ts: unit coverage for the claim hook's success, wallet-rejection, and no-wallet-connected paths Closes EarnQuestOne#1965, EarnQuestOne#1964, EarnQuestOne#1941, EarnQuestOne#1939
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small, additive test files — no existing files modified, so this should apply without conflicts.
What's included
BackEnd/src/modules/quests/quests-pagination.spec.ts— verifies the existing keyset/cursor pagination inQuestsService.findAllsets/omitsnextCursorcorrectly and filters bycreatedAtrather than an offset.BackEnd/src/modules/quests/quests-cache.spec.ts— verifiesGET /questsresults are served from the Redis cache on a hit (no DB query) and populate the cache on a miss.FrontEnd/my-app/tests/a11y/quest-wizard-wallet-modal.test.ts— axe-core coverage for the quest creation wizard (/en/quests/create) and the wallet connect modal, picked up automatically by the existing a11y Playwright config alongsideaxe-smoke.test.ts/modal-focus.test.ts.FrontEnd/my-app/lib/hooks/useClaim.test.ts— unit coverage for the claim hook's success, wallet-rejection, and no-wallet-connected paths.Issues closed
Closes #1965
Closes #1964
Closes #1941
Closes #1939