Add certified AIG resynthesis benchmark#95
Conversation
🤖 AI Code Review (gemini-3-flash-preview)🇬🇧 English Analysis1. Executive Summary
2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
5. Security & Privacy Check
🇨🇳 中文分析1. 摘要
2. AI 成分分析
3. 工程与经济评估
4. 质量保证
5. 安全与隐私检查
|
|
Review — CertifiedAIGResynthesis (PR #95) Thank you for contributing CertifiedAIGResynthesis. This PR excels in engineering value, verification mechanism, and search space design, with most of the core work being of high quality. Detailed analysis below: 1. Domain, Economic Value, and Frontier-Eng Fit ✅ EDA logic synthesis (AIG resynthesis) is a real engineering domain — it is the core engine of open-source tools such as ABC and Mockturtle. Better area and depth translate directly into reduced chip cost and power consumption, giving the task clear economic value. The task requires the agent to discover locally equivalent rewrite rules on a shared DAG, starting from a feasible baseline and iteratively improving via a verifier. This aligns well with Frontier-Eng's stated mission. 2. Not purely numerical ✅ The agent edits C++ rewrite strategies (how to enumerate cuts, select divisors, and construct local subgraphs), not numerical parameters. This requires understanding circuit DAG topology, fanout/reconvergence, cut enumeration, and Boolean equivalence — structural engineering reasoning, not parameter optimization. 3. Search space ✅ Each rewrite is bounded by ≤8 leaves, ≤16 divisors, ≤64 ANDs, and ≤20000 total rewrites. The combinatorial explosion makes brute-force search infeasible. The baseline uses only constant propagation, structural hashing, and basic idempotence/complement simplification. A single mux-elimination rule was verified to achieve a 13.6% improvement, confirming substantial headroom. 4. Evaluator and engineering verification ✅ This is the strongest part of the PR. After the candidate runs,
The scoring formula 5. Constraints and verifier enforcement ✅
6. Baseline experiment ✅
Issues to address before merging Issue 1: No test file This PR has zero tests — no
(The README lists g++ as a prerequisite, so assuming g++ in tests is reasonable.) Issue 2: Workload loop lacks per-workload error isolation The workload loop (lines 920–990) has no try/except. If workload 3 fails (candidate crash, certificate parse error, or timeout), the entire evaluation terminates with Issue 3: Missing RLIMIT_NPROC in The try:
resource.setrlimit(resource.RLIMIT_NPROC, (64, 64))
except (AttributeError, ValueError, OSError):
passNon-blocking suggestion The workload IDs in Summary The core problem definition, independent exhaustive truth-table checker, search space design, and baseline documentation are all well-executed. The three issues above should be fixed before merging. The domain and approach are a strong fit for Frontier-Eng. Ready to merge after those fixes. |
Summary
ElectronicDesignAutomation/CertifiedAIGResynthesis, a proof-carrying Boolean optimization benchmarkWhy
This provides a computational-logic frontier task that directly transforms and measures Boolean DAGs rather than simulating a system. The open search problem is to coordinate local equivalences, divisor reuse, balancing, and reconvergent-DAG effects while retaining independently checkable correctness.
The task is self-contained and uses only Python and C++17. It needs no Docker, GPU, network access, external solver, downloaded circuit assets, or vendor EDA tools.
Validation
main:valid=1.0combined_score=1.0algorithm.iterations=0valid=1.0combined_score=1.0git diff --cached --checkand C++17 warning checks passed