fix: check rule status before suggesting to delete/update it - #24
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the rule-management tool descriptions to explicitly require checking a rule’s status before recommending edits or deletions, aligning agent guidance with the “rule must be disabled” constraint.
Changes:
- Updated
edit_ruletool description to instruct checkingread_rulestatus first and to reference status in the related-tools hint. - Updated
delete_ruletool description to instruct checkingread_rulestatus first and addedread_ruleto related tools. - Minor formatting cleanup in
Serverclass declaration area.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/integration/schemas/edit_rule.json | Updates schema description text to require checking rule status via read_rule before proposing edits. |
| tests/integration/schemas/delete_rule.json | Updates schema description text to require checking status via read_rule before proposing deletion; adds read_rule to related tools. |
| src/enapter_mcp_server/mcp/server.py | Mirrors the schema description updates in the tool docstrings for edit_rule and delete_rule. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.