Skip to content

fix: check rule status before suggesting to delete/update it - #24

Merged
rnovatorov merged 1 commit into
mainfrom
fix/rule-flow
Jul 16, 2026
Merged

fix: check rule status before suggesting to delete/update it#24
rnovatorov merged 1 commit into
mainfrom
fix/rule-flow

Conversation

@anataty

@anataty anataty commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the rule-management tool descriptions to explicitly require checking a rule’s status before recommending edits or deletions, aligning agent guidance with the “rule must be disabled” constraint.

Changes:

  • Updated edit_rule tool description to instruct checking read_rule status first and to reference status in the related-tools hint.
  • Updated delete_rule tool description to instruct checking read_rule status first and added read_rule to related tools.
  • Minor formatting cleanup in Server class declaration area.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/integration/schemas/edit_rule.json Updates schema description text to require checking rule status via read_rule before proposing edits.
tests/integration/schemas/delete_rule.json Updates schema description text to require checking status via read_rule before proposing deletion; adds read_rule to related tools.
src/enapter_mcp_server/mcp/server.py Mirrors the schema description updates in the tool docstrings for edit_rule and delete_rule.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rnovatorov
rnovatorov merged commit cff0f46 into main Jul 16, 2026
4 checks passed
@rnovatorov
rnovatorov deleted the fix/rule-flow branch July 16, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants