feat(dashboard): preserve context for result row details#1449
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
bfb6798
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://105c456c.agentv.pages.dev |
| Branch Preview URL: | https://review-av-2s7-ux-gap-audit.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
av-2s7.2andav-2s7.10.Bead recommendations
av-2s7.2: real gap, but narrower than a new dashboard surface. Before this change, opening a result row used the standalone eval detail route, so the dense table, active filters, score columns, and table position were no longer visible. This PR keeps the table mounted and opens the existingEvalDetailtabs in a contextual panel keyed byresults_detail.av-2s7.10: should be closed as already covered or narrowed to a future convenience task only. Current Dashboard Analytics already supports aggregated experiment x target comparison,GET /api/compare?baseline=<target>baseline deltas/normalized gain, mutable tags for baseline labeling, and Per run mode where users select 2+ runs and compare them side-by-side by test case.Verification
bunx biome check apps/dashboard/src/components/ResultTable.tsx apps/web/src/content/docs/docs/tools/dashboard.mdxbun --filter @agentv/dashboard testbun --filter @agentv/dashboard buildagent-browseragainst localagentv dashboard --single --port 4127:/evals/...detail route did not preserve the dense result table context.Private visual evidence:
EntityProcess/agentv-privatebranchevidence/av-2s7-ux-gap-audit, commit0760b89, fileevidence/av-2s7-ux-gap-audit/result-detail-panel.png.