fix(parse): return undefined instead of throwing on invalid dimension#272
Open
spokodev wants to merge 1 commit into
Open
fix(parse): return undefined instead of throwing on invalid dimension#272spokodev wants to merge 1 commit into
spokodev wants to merge 1 commit into
Conversation
A number followed by an identifier that is not an angle unit made the tokenizer emit an undefined token, which crashed consumeCoords with a TypeError. parse() now returns undefined for such input, as it does for other unparseable strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse()is documented to returnundefinedfor input it cannot handle, but it threw aTypeErroron valid CSS syntax that it does not support.num()returnsundefinedwhen a number is followed by a non-angle identifier, thatundefinedwas pushed into the token stream, andconsumeCoordslater dereferenced it. Inputs such asparse('rgb(1px 2 3)'),parse('hsl(90DEG 100% 50%)'), andparse('rgb(1 2 3 / 1px)')threwCannot read properties of undefinedinstead of returningundefined.This guards the alpha dereference and returns
undefinedwhen the token stream contains a gap. Adds a test that the listed inputs returnundefinedrather than throw.