Rewrite fingerprinted srcset image references#625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PowerForge now rewrites local image candidates in
srcsetandimagesrcsetwhen asset hashing moves those files to fingerprinted names. It preserves descriptors, query strings, fragments, and inlinedata:URLs, including descriptorless candidates separated by commas.This lets PowerForge websites content-hash mutable screenshots and responsive images without leaving references to files that no longer exist.
Validation
OptimizeDetailedtests passsource[srcset],img[srcset], preloadimagesrcset, query/fragment suffixes, descriptorless candidates, anddata:URLsReview
An independent local review found a
data:URL boundary issue. The fix was confirmed, and a directly caused descriptorless-candidate regression was then fixed and covered by the final focused test.