chore: remove stale content/browser/Event Loop/ leftover files#23
Merged
Conversation
An earlier sync (before the Obsidian-Vault itself was flattened) had recreated this nested folder in content/. sync-obsidian-notes.sh only copies/overwrites from the vault — it never prunes files that no longer exist there — so these stale duplicates of Rendering Pipeline.md, Event Loop, Microtasks, Macrotasks.md and index.md kept shipping to the live site even after the vault was fixed and re-synced.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughEvent Loop and Rendering Pipeline documentation pages were deleted, leaving the Event Loop index empty. Two Vue translation manifest entries were reordered without changing their hashes. ChangesEvent Loop documentation cleanup
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync-obsidian-notes.shonly copies/overwrites from the vault (cp -r) — it never prunes files that no longer exist there. An earlier sync (before Obsidian-Vault itself got the Event Loop/ → browser/ flatten) had recreated the old nestedcontent/browser/Event Loop/folder; every later sync left those stale duplicates in place since the vault copy always overwrote the same paths but never touchedcontent/browser/Event Loop/*.content/browser/) now only has the flat files.Test plan
npm run translate:checkreports content-ru/ up to date (manifest auto-cleaned by pre-commit hook)npm run checkpassesSummary by CodeRabbit