Skip to content

chore: remove stale content/browser/Event Loop/ leftover files#23

Merged
Faustze merged 1 commit into
mainfrom
chore/remove-stale-event-loop-dir
Jul 24, 2026
Merged

chore: remove stale content/browser/Event Loop/ leftover files#23
Faustze merged 1 commit into
mainfrom
chore/remove-stale-event-loop-dir

Conversation

@Faustze

@Faustze Faustze commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • sync-obsidian-notes.sh only copies/overwrites from the vault (cp -r) — it never prunes files that no longer exist there. An earlier sync (before Obsidian-Vault itself got the Event Loop/ → browser/ flatten) had recreated the old nested content/browser/Event Loop/ folder; every later sync left those stale duplicates in place since the vault copy always overwrote the same paths but never touched content/browser/Event Loop/*.
  • Removed the stale folder entirely. The vault (and this repo's content/browser/) now only has the flat files.

Test plan

  • npm run translate:check reports content-ru/ up to date (manifest auto-cleaned by pre-commit hook)
  • npm run check passes

Summary by CodeRabbit

  • Documentation
    • Removed the Event Loop and Rendering Pipeline documentation pages.
    • Removed the Event Loop section overview and its navigation links.
    • Reordered two translation manifest entries without changing their content.

An earlier sync (before the Obsidian-Vault itself was flattened) had
recreated this nested folder in content/. sync-obsidian-notes.sh only
copies/overwrites from the vault — it never prunes files that no longer
exist there — so these stale duplicates of Rendering Pipeline.md,
Event Loop, Microtasks, Macrotasks.md and index.md kept shipping to the
live site even after the vault was fixed and re-synced.
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: da8883c8-c1bc-45c8-8a61-111464fe2d6e

📥 Commits

Reviewing files that changed from the base of the PR and between 2b3244a and 0aba945.

📒 Files selected for processing (4)
  • content-ru/.translation-manifest.json
  • content/browser/Event Loop/Event Loop, Microtasks, Macrotasks.md
  • content/browser/Event Loop/Rendering Pipeline.md
  • content/browser/Event Loop/index.md
💤 Files with no reviewable changes (3)
  • content/browser/Event Loop/Event Loop, Microtasks, Macrotasks.md
  • content/browser/Event Loop/Rendering Pipeline.md
  • content/browser/Event Loop/index.md

📝 Walkthrough

Walkthrough

Event Loop and Rendering Pipeline documentation pages were deleted, leaving the Event Loop index empty. Two Vue translation manifest entries were reordered without changing their hashes.

Changes

Event Loop documentation cleanup

Layer / File(s) Summary
Remove Event Loop documentation
content/browser/Event Loop/*
Deletes the Event Loop, Rendering Pipeline, and index Markdown content.
Reorder translation manifest entries
content-ru/.translation-manifest.json
Swaps the Vue reactivity and compiler entries while preserving both hashes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • Faustze/notes#21: Updates and renames the same Event Loop documentation pages and cross-links.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes removal of stale Event Loop files.
Description check ✅ Passed The description includes a clear summary and test plan and matches the repository template well.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-stale-event-loop-dir

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Faustze
Faustze merged commit e7e3dbe into main Jul 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant