fix: omit empty expiry from PIS connect payload#11
Open
fintecturegit wants to merge 1 commit into
Open
Conversation
The form submits an empty expiry when the field is left blank, which was passed through as `expiry: ""`. With fintecture-client >= 2.5.x this is forwarded to meta.expiry, and the API rejects it (406: "$/meta/expiry must match pattern ^[0-9]+$"). Falling back to undefined when blank omits the field entirely, matching the simulator's handling. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PIS connect form passes
expiry: req.body.expirydirectly. When the expiry field is left blank, that sendsexpiry: "", whichfintecture-client>= 2.5.x forwards tometa.expiry. The API then rejects it:Falling back to
undefinedwhen blank omits the field entirely (JSON.stringifydropsundefined), matching how the simulator already handles it.Change
Context
Surfaced when
sample-pis-connect-testwas upgraded from fintecture-client 2.0.2 to 2.5.3 (2.0.2 didn't forwardexpiry; 2.5.x does). Already hotfixed on the deployed instance; this brings the repo in line.🤖 Generated with Claude Code