packaging: Windows GUI installer (Inno Setup)

[Admnwk]

What & why

A classic Windows setup.exe — the clicky front door ex-Advantage users expect — as a thin GUI shell over the same machinery as the console wizard (openads_serverd --setup). It asks for the data directory, wire port, Studio console and auto-start, writes openads.ini, and optionally registers the Windows service via openads_serverd --install-service --config <ini>. No install logic is duplicated; Linux/macOS use the console wizard directly.

• packaging/windows/openads-setup.iss — Inno Setup script: custom settings/options pages, port validation, the ini writer and service registration in CurStepChanged(ssPostInstall); uninstall drops the service first. Version is a build-time define (/DAppVer) so it is not hard-coded; binaries come from a staging folder (/DSrcDir, e.g. an extracted release zip or cpack output).
• packaging/windows/README.md — how to build it (ISCC) and what it does.

Pairs with the --setup wizard (#89) and the CPack packaging (#91): point /DSrcDir at the CPack ZIP and iscc wraps it into a setup.exe.

Honest caveat

This is Windows-only and is not wired into CI here. I reviewed it carefully but could not compile it in my environment (no Inno Setup toolchain). Please run iscc on a Windows box / CI to verify before shipping a release.

Naming

Only nominative references to Advantage/ARC for compatibility; no third-party brand claimed.

[gemini-code-assist]

Code Review

This pull request introduces a Windows installer using Inno Setup (openads-setup.iss) along with a supporting README.md to guide users through the build and installation process. The installer provides a GUI wizard to configure server settings, write the configuration file, and register the application as a Windows service. The feedback recommends defaulting the data directory to {commonappdata} instead of {autopf} to avoid write-permission issues, adding validation to prevent port conflicts, starting the service automatically post-install, and stopping the service synchronously during uninstallation to prevent file-in-use locks.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Storing dynamic database files under Program Files ({autopf}) is discouraged on Windows due to write-permission restrictions and standard directory layouts. It is highly recommended to default the data directory to {commonappdata} (which resolves to C:\ProgramData), where the service will have appropriate write permissions.

  CfgPage.Values[0] := ExpandConstant('{commonappdata}\OpenADS\data');

[gemini-code-assist]

Add a validation check to ensure that the wire port and the Studio port are not configured to the same value, which would cause a port binding conflict and prevent the server from starting.

    p := StrToIntDef(CfgPage.Values[2], -1);
    if (p < 0) or (p > 65535) then
    begin
      MsgBox('The Studio port must be a number between 0 and 65535.',
             mbError, MB_OK);
      Result := False;
      Exit;
    end;
    if CfgPage.Values[1] = CfgPage.Values[2] then
    begin
      MsgBox('The wire port and the Studio port cannot be the same.',
             mbError, MB_OK);
      Result := False;
    end;

[gemini-code-assist]

After successfully registering the Windows service, it is a better user experience to start the service immediately so the user doesn't have to manually start it or reboot the system.

    if ServiceWanted then
    begin
      if not Exec(ExpandConstant('{app}\openads_serverd.exe'),
                  '--install-service --config "' + iniPath + '"',
                  ExpandConstant('{app}'), SW_HIDE, ewWaitUntilTerminated, rc) then
        MsgBox('Could not launch the service installer.', mbError, MB_OK)
      else if rc <> 0 then
        MsgBox('Service registration returned code ' + IntToStr(rc) +
               '. You can register it later with:'#13#10 +
               '  openads_serverd --install-service --config "' + iniPath + '"',
               mbInformation, MB_OK)
      else
      begin
        Exec('net.exe', 'start openads_serverd', '', SW_HIDE, ewWaitUntilTerminated, rc);
      end;
    end;

[gemini-code-assist]

During uninstallation, stopping the service via --uninstall-service is asynchronous and might not finish before the uninstaller attempts to delete the executable, leading to 'file in use' errors. Running net stop openads_serverd synchronously first ensures the service is fully stopped before file deletion begins.

[UninstallRun]
; Stop the service synchronously to prevent file-in-use locks, then uninstall it.
Filename: "net.exe"; Parameters: "stop openads_serverd"; Flags: runhidden; RunOnceId: "StopOpenadsSvc"
Filename: "{app}\openads_serverd.exe"; Parameters: "--uninstall-service"; Flags: runhidden; RunOnceId: "DelOpenadsSvc"