feat(shell): PATH-based command resolution and completion - #140
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 3bb54d8. Configure here.
| if (dir_len > 0) { | ||
| int n = snprintf(path_buf, buf_size, "%.*s/%s", dir_len, path, name); | ||
| if (n > 0 && n < buf_size && access(path_buf, X_OK) == 0) | ||
| return path_buf; |
There was a problem hiding this comment.
PATH match accepts any node
Medium Severity · Logic Bug
resolve_cmd treats a successful access(..., X_OK) as proof it found the command and stops walking PATH. On this OS, access/faccessat succeeds for any resolvable node, including directories and non-executables, so an earlier shadowing name prevents later valid binaries from being tried and surfaces as command not found.
Reviewed by Cursor Bugbot for commit 3bb54d8. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Made with Cursor