Skip to content

feat(stlxterm): VT100/xterm escape expansion - #142

Closed
FlareCoding wants to merge 1 commit into
pr/pty-winsizefrom
pr/stlxterm-vt100
Closed

feat(stlxterm): VT100/xterm escape expansion#142
FlareCoding wants to merge 1 commit into
pr/pty-winsizefrom
pr/stlxterm-vt100

Conversation

@FlareCoding

Copy link
Copy Markdown
Owner

Summary

Stacked on #141.

Made with Cursor

@cursor

cursor Bot commented Jul 30, 2026

Copy link
Copy Markdown

Current version of PR was reviewed by /review-bugbot on Jul 30, 13:23 PDT. It flagged 2 findings.

Show 2 findings

1. DECSTBM homes wrong cursor row

userland/apps/stlxterm/src/term.c:400 · Medium Severity

After handling DECSTBM (CSI r), the cursor is always placed at screen row 0 instead of the top line of the newly configured scroll region (scroll_top). Programs that set a non-zero top margin (e.g. \e[2;24r) expect the cursor at that margin line; placing it at row 0 breaks origin/region-relative drawing and scrolling.

2. Alt screen keeps scroll margins

userland/apps/stlxterm/src/term.c:157 · Medium Severity

Switching to or from the alternate screen (DECSET 1047/1049) saves and restores cell buffers and cursor position but never resets or restores scroll_top/scroll_bottom. xterm-compatible full-screen apps expect full-window margins on the alt buffer and the previous margins restored on exit.

Bugbot on commit ac5ede6 is skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant