You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current version of PR was reviewed by /review-bugbot on Jul 30, 13:23 PDT. It flagged 2 findings.
Show 2 findings
1. DECSTBM homes wrong cursor row
userland/apps/stlxterm/src/term.c:400 · Medium Severity
After handling DECSTBM (CSI r), the cursor is always placed at screen row 0 instead of the top line of the newly configured scroll region (scroll_top). Programs that set a non-zero top margin (e.g. \e[2;24r) expect the cursor at that margin line; placing it at row 0 breaks origin/region-relative drawing and scrolling.
2. Alt screen keeps scroll margins
userland/apps/stlxterm/src/term.c:157 · Medium Severity
Switching to or from the alternate screen (DECSET 1047/1049) saves and restores cell buffers and cursor position but never resets or restores scroll_top/scroll_bottom. xterm-compatible full-screen apps expect full-window margins on the alt buffer and the previous margins restored on exit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #141.
Made with Cursor