Skip to content

Validate optional dependency feature names#3364

Merged
FlorianPfaff merged 2 commits into
mainfrom
codex/input-validation
Jun 29, 2026
Merged

Validate optional dependency feature names#3364
FlorianPfaff merged 2 commits into
mainfrom
codex/input-validation

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • validate optional dependency feature names before using them in user-facing install diagnostics
  • add regression coverage for blank feature names

Bug fixed

require_optional_dependency(..., feature=" ") previously treated a blank feature as absent, producing a less precise optional dependency diagnostic instead of rejecting the malformed caller input. This now matches the existing validation contract for package and extra.

Validation

  • Branch diff checked against current main: 2 commits, 2 files changed
  • Targeted test added in tests/test_optional_dependencies.py
  • Full local test execution was not available in this connector-only GitHub session.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 65.39s
✅ JSON prettier 7 0 0 0 0.7s
✅ JSON v8r 7 0 0 4.69s
✅ MARKDOWN markdownlint 68 0 0 0 1.72s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.67s
✅ PYTHON black 1094 0 0 0 53.03s
✅ PYTHON isort 1094 0 0 0 2.87s
✅ REPOSITORY checkov yes no no 43.13s
✅ REPOSITORY gitleaks yes no no 11.54s
✅ REPOSITORY git_diff yes no no 0.06s
✅ REPOSITORY secretlint yes no no 36.07s
✅ REPOSITORY syft yes no no 3.4s
✅ REPOSITORY trivy-sbom yes no no 7.5s
✅ REPOSITORY trufflehog yes no no 17.06s
✅ YAML prettier 11 0 0 0 0.59s
✅ YAML v8r 11 0 0 10.96s
✅ YAML yamllint 11 0 0 0.53s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit c08f253 into main Jun 29, 2026
16 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant