Skip to content

Fix PyTorch gamma array-like inputs#3365

Closed
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-pytorch-gamma-arraylike
Closed

Fix PyTorch gamma array-like inputs#3365
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-pytorch-gamma-arraylike

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • patch the PyTorch gamma backend entry point so scalar and array-like inputs are first coerced through the active backend array constructor
  • update both the public pyrecest.backend.gamma facade and the raw pyrecest._backend.pytorch.gamma entry point
  • add a subprocess regression test for scalar, list, and raw-backend gamma calls

Bug fixed

The PyTorch backend exported gamma, but its implementation called torch.special.gammaln directly. That function only accepts tensors, so calls such as backend.gamma(5.0) or backend.gamma([0.5, 1.0, 5.0]) failed under PYRECEST_BACKEND=pytorch even though other unary backend functions accept scalar and array-like inputs.

Testing

  • Added tests/backend_support/test_pytorch_gamma_contract.py
  • Locally syntax-checked the modified src/pyrecest/__init__.py and the new regression test with python -m py_compile

Full test execution was not possible in this execution environment because the repository cannot be cloned or installed from GitHub here.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 76.02s
✅ JSON prettier 7 0 0 0 0.95s
✅ JSON v8r 7 0 0 4.35s
✅ MARKDOWN markdownlint 68 0 0 0 1.98s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.71s
✅ PYTHON black 1095 0 0 0 61.34s
✅ PYTHON isort 1095 1 0 0 5.18s
✅ REPOSITORY checkov yes no no 50.2s
✅ REPOSITORY gitleaks yes no no 10.77s
✅ REPOSITORY git_diff yes no no 0.1s
✅ REPOSITORY secretlint yes no no 36.8s
✅ REPOSITORY syft yes no no 3.49s
✅ REPOSITORY trivy-sbom yes no no 12.35s
✅ REPOSITORY trufflehog yes no no 19.78s
✅ YAML prettier 11 0 0 0 0.7s
✅ YAML v8r 11 0 0 12.84s
✅ YAML yamllint 11 0 0 0.67s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant