Skip to content

Fix cached point-estimate mean extraction#3366

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix-extract-mean-point-estimate-attribute
Jun 29, 2026
Merged

Fix cached point-estimate mean extraction#3366
FlorianPfaff merged 2 commits into
mainfrom
fix-extract-mean-point-estimate-attribute

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • handle get_point_estimate values that are cached attributes as well as callable methods
  • keep the existing fallback order for mu, raw array states, and mean
  • add a focused regression test for Euclidean mean extraction from cached point-estimate adapter objects

Bug fixed

get_extract_mean("euclidean") unconditionally called filter_state.get_point_estimate() whenever the attribute existed. Adapter or state objects that expose a cached point estimate under that public attribute therefore failed with TypeError even though the rest of the mean-extraction helper already supports callable-or-attribute style access for mean.

Testing

  • Added tests/evaluation/test_extract_mean_cached_point_estimate.py

I could not run the repository test suite locally because the execution container cannot resolve github.com for a clone/install; CI should run on this PR.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 63.53s
✅ JSON prettier 7 0 0 0 0.78s
✅ JSON v8r 7 0 0 4.42s
✅ MARKDOWN markdownlint 68 0 0 0 1.67s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.38s
✅ PYTHON black 1095 0 0 0 52.63s
✅ PYTHON isort 1095 0 0 0 3.43s
✅ REPOSITORY checkov yes no no 45.02s
✅ REPOSITORY gitleaks yes no no 11.09s
✅ REPOSITORY git_diff yes no no 0.02s
✅ REPOSITORY secretlint yes no no 30.25s
✅ REPOSITORY syft yes no no 1.69s
✅ REPOSITORY trivy-sbom yes no no 10.97s
✅ REPOSITORY trufflehog yes no no 18.73s
✅ YAML prettier 11 0 0 0 0.58s
✅ YAML v8r 11 0 0 11.23s
✅ YAML yamllint 11 0 0 0.51s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit 6dd6f72 into main Jun 29, 2026
16 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant