Skip to content

Fix PyTorch FFT array-like inputs#3373

Closed
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-pytorch-fft-arraylike-axis-aliases-20260629
Closed

Fix PyTorch FFT array-like inputs#3373
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-pytorch-fft-arraylike-axis-aliases-20260629

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • wrap the PyTorch FFT helpers so they coerce array-like inputs before dispatching to torch.fft
  • accept NumPy-style axes/axis aliases for fftn, ifftn, fftshift, ifftshift, rfft, and irfft
  • reject conflicting torch/NumPy axis aliases explicitly
  • add subprocess regression coverage for the PyTorch backend FFT facade

Bug fixed

The PyTorch FFT submodule previously re-exported raw torch.fft functions. Calls through pyrecest.backend.fft such as fftn([[1.0, 2.0], [3.0, 4.0]], axes=(0, 1)), rfft([...], axis=0), or fftshift([...], axes=0) therefore failed under PYRECEST_BACKEND=pytorch, even though the backend facade generally accepts array-like inputs and NumPy-style argument names.

Testing

  • Added tests/backend_support/test_pytorch_fft_numpy_signature.py.
  • Repository test suite not run in this connector session.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 73.75s
✅ JSON prettier 7 0 0 0 1.48s
✅ JSON v8r 7 0 0 5.49s
✅ MARKDOWN markdownlint 68 0 0 0 1.97s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.92s
✅ PYTHON black 1095 0 0 0 61.65s
✅ PYTHON isort 1095 1 0 0 3.24s
✅ REPOSITORY checkov yes no no 49.64s
✅ REPOSITORY gitleaks yes no no 11.75s
✅ REPOSITORY git_diff yes no no 0.17s
✅ REPOSITORY secretlint yes no no 39.25s
✅ REPOSITORY syft yes no no 4.19s
✅ REPOSITORY trivy-sbom yes no no 9.13s
✅ REPOSITORY trufflehog yes no no 18.05s
✅ YAML prettier 11 0 0 0 0.77s
✅ YAML v8r 11 0 0 11.98s
✅ YAML yamllint 11 0 0 0.48s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant