Skip to content

Fix PyTorch allclose keyword contract#3375

Merged
FlorianPfaff merged 2 commits into
mainfrom
bugfix-pytorch-allclose-keyword
Jun 29, 2026
Merged

Fix PyTorch allclose keyword contract#3375
FlorianPfaff merged 2 commits into
mainfrom
bugfix-pytorch-allclose-keyword

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • adapt the PyTorch backend allclose facade to accept Torch's missing-value keyword
  • patch both public pyrecest.backend.allclose and raw pyrecest._backend.pytorch.allclose at backend registration time
  • add backend-portable regression coverage for the public PyTorch facade

Bug fixed

The PyTorch backend allclose wrapper forwarded atol and rtol but rejected the standard missing-value comparison keyword before reaching torch.allclose. This made otherwise valid backend-compatible code fail under PYRECEST_BACKEND=pytorch.

Testing

  • Local py_compile check of the changed backend adaptation and test files
  • Local standalone Torch smoke check for the missing-value keyword behavior
  • Full repository CI should run on this PR

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) June 29, 2026 09:14
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 64.93s
✅ JSON prettier 7 0 0 0 1.14s
✅ JSON v8r 7 0 0 6.37s
✅ MARKDOWN markdownlint 68 0 0 0 1.79s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.61s
✅ PYTHON black 1094 1 0 0 54.14s
✅ PYTHON isort 1094 1 0 0 2.77s
✅ REPOSITORY checkov yes no no 44.41s
✅ REPOSITORY gitleaks yes no no 11.45s
✅ REPOSITORY git_diff yes no no 0.22s
✅ REPOSITORY secretlint yes no no 42.55s
✅ REPOSITORY syft yes no no 4.14s
✅ REPOSITORY trivy-sbom yes no no 3.79s
✅ REPOSITORY trufflehog yes no no 15.24s
✅ YAML prettier 11 0 0 0 0.72s
✅ YAML v8r 11 0 0 11.38s
✅ YAML yamllint 11 0 0 0.55s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit c721259 into main Jun 29, 2026
16 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant