Fix PyTorch apply_along_axis argument forwarding#3380
Closed
FlorianPfaff wants to merge 3 commits into
Closed
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
apply_along_axisfacade so extra positional and keyword arguments are forwarded to the 1-D callbackapply_along_axis(func1d, axis, arr, *args, **kwargs)contractBug fixed
The PyTorch backend provided a NumPy-style
apply_along_axisimplementation, but its signature only accepted(func, axis, tensor). Valid NumPy-compatible calls such asbackend.apply_along_axis(func, 1, values, scale, offset=...)failed withTypeErrorbefore the callback was invoked.Notes
During connector editing, the package metadata/export tail in
src/pyrecest/__init__.pywas restored explicitly after the runtime patch. The exported API names remain present.Testing
tests/backend_support/test_pytorch_apply_along_axis_contract.py::test_pytorch_apply_along_axis_forwards_callback_arguments