Skip to content

Fix public sequence node flag validation#3381

Merged
FlorianPfaff merged 2 commits into
mainfrom
codex/sa-node-consistency-20260629
Jun 29, 2026
Merged

Fix public sequence node flag validation#3381
FlorianPfaff merged 2 commits into
mainfrom
codex/sa-node-consistency-20260629

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • remove the duplicate pre-validation in the public SequenceAssociationNode wrapper so malformed is_missed_detection values are handled by the base node validator
  • add a regression test for array-like missed-detection flags, which should raise PyRecEst's stable ValueError instead of NumPy truth-value errors

Bug fixed

The public wrapper previously evaluated self.is_missed_detection before scalar-bool validation. For array-like values such as np.array([True, False]), this can raise NumPy's ambiguous truth-value error before PyRecEst's intended validation path runs. Delegating to the base class keeps public import behavior consistent with the core implementation.

Validation

  • inspected branch diff with GitHub compare: 2 commits ahead of main, only 2 files changed
  • local full tests were not run because this environment cannot resolve github.com for cloning/installing the repository

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 75.03s
✅ JSON prettier 7 0 0 0 0.9s
✅ JSON v8r 7 0 0 4.8s
✅ MARKDOWN markdownlint 68 0 0 0 2.24s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.89s
✅ PYTHON black 1095 0 0 0 61.32s
✅ PYTHON isort 1095 1 0 0 4.55s
✅ REPOSITORY checkov yes no no 49.34s
✅ REPOSITORY gitleaks yes no no 11.3s
✅ REPOSITORY git_diff yes no no 0.16s
✅ REPOSITORY secretlint yes no no 35.28s
✅ REPOSITORY syft yes no no 4.24s
✅ REPOSITORY trivy-sbom yes no no 12.55s
✅ REPOSITORY trufflehog yes no no 20.77s
✅ YAML prettier 11 0 0 0 0.75s
✅ YAML v8r 11 0 0 12.55s
✅ YAML yamllint 11 0 0 0.58s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit a7b85b5 into main Jun 29, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant