Skip to content

Backend tools cleanup #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorianPfaff merged 2 commits into from
Jun 29, 2026
Merged

Backend tools cleanup #3382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5fc1df
Deduplicate expected backend names
FlorianPfaff Jun 29, 2026
e5e2fdd
Cover duplicate expected backend names
FlorianPfaff Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pyrecest/backend_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def _normalize_expected_backend_names(
not isinstance(name, str) or not name or name.strip() != name for name in names
):
raise ValueError(message)
return names
return tuple(dict.fromkeys(names))


def assert_backend(expected: str | tuple[str, ...]) -> None:
Expand Down
10 changes: 10 additions & 0 deletions tests/test_backend_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,16 @@ def test_assert_backend_rejects_unexpected_backend():
pyrecest.assert_backend(unexpected)


def test_assert_backend_deduplicates_expected_names_in_error_message():
active = pyrecest.get_backend_name()
unexpected = "jax" if active != "jax" else "numpy"

with pytest.raises(RuntimeError) as excinfo:
pyrecest.assert_backend((unexpected, unexpected))

assert str(excinfo.value).count(unexpected) == 1


@pytest.mark.parametrize(
"expected", [(), ("",), " ", (" numpy",), ("numpy ",), ("numpy", 1), 1]
)
Expand Down
Loading