Skip to content

Normalize sequence association top-k validation errors#3386

Merged
FlorianPfaff merged 2 commits into
mainfrom
codex/seqnode-clean
Jun 29, 2026
Merged

Normalize sequence association top-k validation errors#3386
FlorianPfaff merged 2 commits into
mainfrom
codex/seqnode-clean

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • wrap np.asarray coercion failures in _validate_positive_integer as the stable PyRecEst ValueError
  • add regression coverage for an array-like top_k_terminal_paths object whose conversion raises

Bug fixed

solve_top_k_viterbi_sequence_associations(..., top_k_terminal_paths=bad_array_like) previously leaked the underlying TypeError from NumPy coercion instead of reporting the documented/stable ValueError("top_k_terminal_paths must be a positive integer"). The other scalar validators in this module already normalize coercion failures; this makes the top-k path consistent.

Validation

  • Inspected branch diff against current main: 2 commits, 2 files changed, only the validator and regression test.
  • Full local test execution was not possible because this environment cannot resolve github.com for cloning/installing the repository.

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) June 29, 2026 09:55
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 74.84s
✅ JSON prettier 7 0 0 0 1.0s
✅ JSON v8r 7 0 0 5.6s
✅ MARKDOWN markdownlint 68 0 0 0 1.78s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.84s
✅ PYTHON black 1095 1 0 0 61.1s
✅ PYTHON isort 1095 1 0 0 3.51s
✅ REPOSITORY checkov yes no no 49.07s
✅ REPOSITORY gitleaks yes no no 11.29s
✅ REPOSITORY git_diff yes no no 0.19s
✅ REPOSITORY secretlint yes no no 35.9s
✅ REPOSITORY syft yes no no 5.11s
✅ REPOSITORY trivy-sbom yes no no 12.56s
✅ REPOSITORY trufflehog yes no no 19.36s
✅ YAML prettier 11 0 0 0 0.84s
✅ YAML v8r 11 0 0 10.52s
✅ YAML yamllint 11 0 0 0.54s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit 8e07185 into main Jun 29, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant