Skip to content

Fix PyTorch sort NumPy-style contract#3452

Open
FlorianPfaff wants to merge 7 commits into
mainfrom
chatgpt-fix-pytorch-sort-contract
Open

Fix PyTorch sort NumPy-style contract#3452
FlorianPfaff wants to merge 7 commits into
mainfrom
chatgpt-fix-pytorch-sort-contract

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Add a PyTorch backend sort compatibility shim for NumPy-style axis=None flattening.
  • Accept NumPy sort stability controls via kind="stable" / kind="mergesort" and map them to torch.sort(stable=True).
  • Wire the shim through backend-support initialization so raw PyTorch backend calls are patched even when the selected public backend is NumPy.
  • Add a backend-portable regression covering the raw PyTorch backend and the public PyTorch facade when active.

Bug fixed

The PyTorch backend sort helper exposed a narrower Torch-style signature. Calls that are valid under the PyRecEst/NumPy facade contract, such as sort([[3, 1], [2, 4]], axis=None) or sort([3, 1, 2, 1], kind="stable"), failed instead of matching NumPy-style behavior.

Testing

  • Added tests/backend_support/test_pytorch_sort_raw_backend_contract.py.
  • Not run locally in this connector-only session; CI should run the focused backend regression.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 78.46s
✅ JSON prettier 7 0 0 0 1.21s
✅ JSON v8r 7 0 0 5.67s
✅ MARKDOWN markdownlint 68 0 0 0 1.91s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 1.05s
✅ PYTHON black 1133 6 0 0 65.9s
✅ PYTHON isort 1133 6 0 0 4.45s
✅ REPOSITORY checkov yes no no 50.14s
✅ REPOSITORY gitleaks yes no no 11.32s
✅ REPOSITORY git_diff yes no no 0.15s
✅ REPOSITORY secretlint yes no no 48.66s
✅ REPOSITORY syft yes no no 5.16s
✅ REPOSITORY trivy-sbom yes no no 5.61s
✅ REPOSITORY trufflehog yes no no 18.14s
✅ YAML prettier 11 0 0 0 0.84s
✅ YAML v8r 11 0 0 13.65s
✅ YAML yamllint 11 0 0 0.51s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant