Skip to content

Fix raw PyTorch reshape under non-PyTorch backends#3453

Open
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-raw-pytorch-reshape-default-backend
Open

Fix raw PyTorch reshape under non-PyTorch backends#3453
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-raw-pytorch-reshape-default-backend

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Patch the PyTorch reshape backend contract hook so it always patches raw pyrecest._backend.pytorch.reshape, even when the selected public backend is NumPy.
  • Use pyrecest._backend.pytorch.array inside the wrapper rather than the active public backend's array, so raw PyTorch calls produce tensors under non-PyTorch public backends.
  • Extend the reshape regression test to cover direct raw PyTorch usage after PYRECEST_BACKEND=numpy.

Bug fixed

_adapt_pytorch_reshape_contract() returned early unless the active public backend was PyTorch. As a result, importing PyRecEst with PYRECEST_BACKEND=numpy and then calling pyrecest._backend.pytorch.reshape([1, 2, 3, 4], (2, 2)) still exposed raw torch.reshape, which rejects array-like inputs instead of honoring the NumPy-style PyRecEst backend contract.

Testing

  • python -m py_compile /tmp/_backend_submodules.py
  • python -m py_compile /tmp/test_pytorch_reshape_contract.py

Full test suite was not run locally because the execution container cannot reach GitHub to clone/install the repository dependencies; CI should run the focused regression.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 77.4s
✅ JSON prettier 7 0 0 0 0.94s
✅ JSON v8r 7 0 0 4.37s
✅ MARKDOWN markdownlint 68 0 0 0 1.79s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.77s
✅ PYTHON black 1131 4 0 0 63.61s
✅ PYTHON isort 1131 4 0 0 4.0s
✅ REPOSITORY checkov yes no no 49.49s
✅ REPOSITORY gitleaks yes no no 11.34s
✅ REPOSITORY git_diff yes no no 0.21s
✅ REPOSITORY secretlint yes no no 38.03s
✅ REPOSITORY syft yes no no 5.24s
✅ REPOSITORY trivy-sbom yes no no 12.16s
✅ REPOSITORY trufflehog yes no no 21.07s
✅ YAML prettier 11 0 0 0 0.83s
✅ YAML v8r 11 0 0 11.44s
✅ YAML yamllint 11 0 0 0.65s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant