Fix raw PyTorch reshape under non-PyTorch backends#3453
Open
FlorianPfaff wants to merge 2 commits into
Open
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
reshapebackend contract hook so it always patches rawpyrecest._backend.pytorch.reshape, even when the selected public backend is NumPy.pyrecest._backend.pytorch.arrayinside the wrapper rather than the active public backend'sarray, so raw PyTorch calls produce tensors under non-PyTorch public backends.PYRECEST_BACKEND=numpy.Bug fixed
_adapt_pytorch_reshape_contract()returned early unless the active public backend was PyTorch. As a result, importing PyRecEst withPYRECEST_BACKEND=numpyand then callingpyrecest._backend.pytorch.reshape([1, 2, 3, 4], (2, 2))still exposed rawtorch.reshape, which rejects array-like inputs instead of honoring the NumPy-style PyRecEst backend contract.Testing
python -m py_compile /tmp/_backend_submodules.pypython -m py_compile /tmp/test_pytorch_reshape_contract.pyFull test suite was not run locally because the execution container cannot reach GitHub to clone/install the repository dependencies; CI should run the focused regression.