Skip to content

Fix raw PyTorch broadcast_arrays under NumPy backend#3454

Open
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-raw-pytorch-broadcast-arrays-default-backend
Open

Fix raw PyTorch broadcast_arrays under NumPy backend#3454
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-raw-pytorch-broadcast-arrays-default-backend

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Patch raw pyrecest._backend.pytorch.broadcast_arrays from backend-support initialization so it accepts NumPy-style array-like inputs even when the public backend is not PyTorch.
  • Keep the active public PyTorch backend synchronized when PYRECEST_BACKEND=pytorch.
  • Add a subprocess regression for PYRECEST_BACKEND=numpy followed by direct raw PyTorch broadcast_arrays calls with list/scalar inputs.

Bug fixed

The raw PyTorch backend currently exposes torch.broadcast_tensors directly as broadcast_arrays. When the process selects the NumPy public backend and user code imports pyrecest._backend.pytorch directly, calls such as raw_backend.broadcast_arrays([1, 2], raw_backend.array([[3], [4]])) still reach Torch-native input validation and reject the list input. The patch normalizes all operands through the raw PyTorch backend array constructor before calling torch.broadcast_tensors.

Testing

  • Not run locally in this connector session; added focused regression coverage in tests/backend_support/test_raw_pytorch_broadcast_arrays_default_backend.py.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 62.98s
✅ JSON prettier 7 0 0 0 0.98s
✅ JSON v8r 7 0 0 5.06s
✅ MARKDOWN markdownlint 68 0 0 0 1.53s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.84s
✅ PYTHON black 1132 4 0 0 57.14s
✅ PYTHON isort 1132 4 0 0 2.8s
✅ REPOSITORY checkov yes no no 43.19s
✅ REPOSITORY gitleaks yes no no 10.44s
✅ REPOSITORY git_diff yes no no 0.14s
✅ REPOSITORY secretlint yes no no 43.15s
✅ REPOSITORY syft yes no no 6.03s
✅ REPOSITORY trivy-sbom yes no no 5.69s
✅ REPOSITORY trufflehog yes no no 15.26s
✅ YAML prettier 11 0 0 0 0.66s
✅ YAML v8r 11 0 0 10.82s
✅ YAML yamllint 11 0 0 0.47s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant