Skip to content

Remove badgeComponent experimental flag requirement#50

Merged
javier-godoy merged 1 commit into
masterfrom
issue-49
Jul 14, 2026
Merged

Remove badgeComponent experimental flag requirement#50
javier-godoy merged 1 commit into
masterfrom
issue-49

Conversation

@paodb

@paodb paodb commented Jul 3, 2026

Copy link
Copy Markdown
Member

The Badge component is stable and non-experimental as of Vaadin 25.2, so the badgeComponent feature flag is no longer needed to use this add-on.

  • Delete src/main/resources/vaadin-featureflags.properties
  • Upgrade vaadin.version to 25.2.1
  • Drop the now-orphan vaadin-featureflags.properties jar exclusion
  • Bump add-on version to 2.1.0-SNAPSHOT
  • Update README supported versions and remove the flag-enabling section

Close #49

Summary by CodeRabbit

  • Documentation

    • Clarified supported Vaadin version compatibility with explicit mappings for add-on versions 2.0 and 2.1.
    • Removed outdated setup guidance for the badge component.
  • Chores

    • Updated the add-on to the 2.1.0 release line and aligned it with a newer Vaadin platform version.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Bumps project version to 2.1.0-SNAPSHOT and Vaadin dependency to 25.2.1, removes the experimental badge component feature flag property, updates the maven-jar-plugin exclusion list accordingly, and revises README to document version mappings and drop the badge-enablement instructions.

Changes

Badge component no longer experimental

Layer / File(s) Summary
Version bump and feature flag removal
pom.xml, src/main/resources/vaadin-featureflags.properties
Project version raised to 2.1.0-SNAPSHOT, Vaadin BOM bumped to 25.2.1, the badge component experimental flag entry removed, and jar-plugin exclusions updated to exclude flow-build-info.json instead of the feature flags file.
README version and guide updates
README.md
Compatibility section now explicitly maps Vaadin 25.1 to add-on 2.0 and Vaadin 25.2+ to add-on 2.1; the "Enabling the Badge component" section is removed from the Developer Guide.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: scardanzan, javier-godoy

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR removes the feature flag file, upgrades Vaadin to 25.2.1, and updates docs, matching #49's request to drop the experimental flag requirement.
Out of Scope Changes check ✅ Passed The version bump and README updates support the same flag-removal change and do not introduce unrelated scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: removing the badgeComponent experimental flag requirement.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-49

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

@paodb
paodb requested review from javier-godoy and scardanzan July 3, 2026 21:10
@paodb
paodb marked this pull request as ready for review July 3, 2026 21:10
@javier-godoy
javier-godoy merged commit 652ec07 into master Jul 14, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

Badge component is no longer experimental in Vaadin 25.2

2 participants