Skip to content

Bundle a local json-digger copy to support Vaadin 25.2#98

Merged
javier-godoy merged 3 commits into
masterfrom
fix/issue-97-json-digger-vaadin25
Jul 16, 2026
Merged

Bundle a local json-digger copy to support Vaadin 25.2#98
javier-godoy merged 3 commits into
masterfrom
fix/issue-97-json-digger-vaadin25

Conversation

@paodb

@paodb paodb commented Jul 16, 2026

Copy link
Copy Markdown
Member

Fix Vaadin 25.2 compatibility (memoize is not a function, #97)

json-digger@2.0.2's published bundle is a broken webpack dev build (its source has a stray require("webpack")) that fails under Vaadin 25's Vite build. Since there's no upstream fix and the JSONDigger global is still required, this replaces the bundle import with a local corrected copy of its source (only the stray require removed, export converted to ESM; MIT header preserved). Works on Vaadin 14, 23, 24 and 25.

Close #97

Summary by CodeRabbit

  • New Features

    • Added local JSON tree management support for improved component compatibility.
    • Updated the Vaadin 25 profile to version 25.2.3.
  • Bug Fixes

    • Improved frontend module loading by using the bundled JSON tree utility.
  • Configuration

    • Added the Lumo theme setting for test resources.
    • Updated packaging and license handling for bundled frontend assets.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Changes

The pull request vendors JSONDigger as a local ES module, updates fc-orgchart.js to import it locally, excludes the vendored source from license processing, adjusts demo JAR contents, sets the demo theme to LUMO, and updates the Vaadin 25 profile to 25.2.3.

JSONDigger vendoring and runtime integration

Layer / File(s) Summary
Vendored JSONDigger implementation
src/main/resources/META-INF/frontend/json-digger.js
Adds JSON tree lookup, matching, navigation, mutation, update, removal, validation, and default ES-module export behavior.
Runtime JSONDigger source selection
src/main/resources/META-INF/frontend/fc-orgchart.js, pom.xml
Switches the runtime import to the local module and excludes the vendored MIT source from license processing.
Maven demo and Vaadin configuration
pom.xml, src/test/resources/META-INF/dynamic-theme.properties
Excludes the dynamic theme properties from the demo test JAR, sets the theme to LUMO, and updates Vaadin to 25.2.3.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The local json-digger replacement and Vaadin 25.2.3 demo profile update address the reported demo-site load failure.
Out of Scope Changes check ✅ Passed The other edits are supporting build and packaging adjustments for the same compatibility fix, not unrelated scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: bundling a local json-digger copy for Vaadin 25.2 compatibility.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-97-json-digger-vaadin25

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@paodb
paodb marked this pull request as ready for review July 16, 2026 15:44
@paodb
paodb requested review from javier-godoy and scardanzan July 16, 2026 15:45
@javier-godoy
javier-godoy merged commit 312c39f into master Jul 16, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Jul 16, 2026
@javier-godoy
javier-godoy deleted the fix/issue-97-json-digger-vaadin25 branch July 16, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

Vaadin 25.2: add-on fails in demo site

2 participants