Bundle a local json-digger copy to support Vaadin 25.2#98
Merged
Conversation
WalkthroughChangesThe pull request vendors JSONDigger as a local ES module, updates fc-orgchart.js to import it locally, excludes the vendored source from license processing, adjusts demo JAR contents, sets the demo theme to LUMO, and updates the Vaadin 25 profile to 25.2.3. JSONDigger vendoring and runtime integration
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
javier-godoy
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fix Vaadin 25.2 compatibility (memoize is not a function, #97)
json-digger@2.0.2's published bundle is a broken webpack dev build (its source has a stray require("webpack")) that fails under Vaadin 25's Vite build. Since there's no upstream fix and the JSONDigger global is still required, this replaces the bundle import with a local corrected copy of its source (only the stray require removed, export converted to ESM; MIT header preserved). Works on Vaadin 14, 23, 24 and 25.
Close #97
Summary by CodeRabbit
New Features
Bug Fixes
Configuration