fix(error): replace 'parsed: any' with unknown + readField helper (#361) - #406
Open
jdjioe5-cpu wants to merge 1 commit into
Open
fix(error): replace 'parsed: any' with unknown + readField helper (#361)#406jdjioe5-cpu wants to merge 1 commit into
jdjioe5-cpu wants to merge 1 commit into
Conversation
…owwStar#361) Closes FlowwStar#361. - app/error.tsx: remove the eslint-disable no-unsafe-assignment on parsed: any. - Type JSON.parse(trimmed) as unknown, narrow to object via typeof, and walk it via a new readField(obj, keys) helper that returns the first defined non-null value across a candidate key list. - Use it for both code (code / error_code / err) and detail (message / error / reason / detail). Existing precedence is preserved. No behavior change for well-formed RPC error payloads; the file no longer requires the lint suppression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #361. Replaces parsed: any with unknown + a narrow readField(obj, keys) helper. No behavior change; drops the eslint-disable line.