Fix/issues 281 282 283 287#414
Merged
Austinaminu2 merged 4 commits intoJul 26, 2026
Merged
Conversation
…and test The hooks/useNotifications.ts file is a dead scaffold with no importers. The actual implementation is in hooks/use-notifications.ts which is used by components/layout/notification-bell.tsx. Removing the duplicate reduces confusion for future contributors.
Both hooks/useBulkActions.ts and hooks/useBulkSelect.ts have no importers outside their test files. Removing unused code reduces maintenance surface and prevents contributor confusion when searching for bulk-action logic.
…alue Previously, a single stream with an unknown token would set totalUsd to null for the entire portfolio, hiding USD values for all known tokens. Now: - Only sum USD values for streams with known/priced tokens (XLM, USDC, EURC) - Unknown tokens are silently skipped instead of nulling the aggregate - Returns null only when ALL streams use unknown tokens - Added test cases to verify the fix handles mixed known/unknown tokens
The error message mapper now recognizes and handles all Soroban contract error codes (Error(Contract, #N)) from the StreamError enum (1-20) with specific, actionable error messages for each code. This replaces the previous behavior where contract-level failures fell through to the generic 'Transaction failed' message. Each error now includes: - Descriptive message identifying the specific failure - Actionable suggestion for recovery - Appropriate category (user, contract, or network) - Fallback patterns preserved for non-contract errors Patterns match the format: Error(Contract, #N) with flexible whitespace.
|
@Xoulomon Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance: Remove dead code and fix token handling
Changes
useNotifications.ts,useBulkActions.ts, anduseBulkSelect.tshooksCloses