Skip to content

fix: prevent interactions on locked dropdowns#94

Merged
Footagesus merged 1 commit into
Footagesus:mainfrom
BitRevenant:FixDropdownLocked
Jun 30, 2026
Merged

fix: prevent interactions on locked dropdowns#94
Footagesus merged 1 commit into
Footagesus:mainfrom
BitRevenant:FixDropdownLocked

Conversation

@BitRevenant

@BitRevenant BitRevenant commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes a critical issue where locked dropdowns could still be opened, selected values could be changed, and callbacks could be triggered.

Changes

  • Use the shared Dropdown.Locked state instead of a stale copied boolean.
  • Prevent locked dropdowns from opening.
  • Prevent item selection and value changes while locked.
  • Block callbacks when the dropdown is locked.
  • Close the menu if the dropdown is locked while open.
  • Handle delayed opening safely.

Testing

  • Verified the final diff with git diff --check.
  • Confirmed all internal factory calls use the updated signature.
  • Locally compiled and tested. No regressions found and the fix works.

Closes #93

@Footagesus

Copy link
Copy Markdown
Owner

👌

@Footagesus
Footagesus merged commit d3f694e into Footagesus:main Jun 30, 2026
1 check failed
article-hub-studio pushed a commit to article-hub-studio/WindUI-Skibidi that referenced this pull request Jul 23, 2026
- Add TypeWindow presets (modern/default) mapped to visual config
- Refactor cloneref into shared module (src/utils/cloneref.lua), update 19 files
- Fix Dropdown.Locked Footagesus#94 - nil check before MenuCanvas.Visible
- Fix Section bg custom themes - only apply ThemeTag when Box=true
- Fix Colorpicker Round() type-safe + operator precedence in transparency
- Fix Viewport pinch outside - reset Pinching on End/Cancel
- Fix Window multi-finger drag Footagesus#79 - add TouchEnded handler
- Install 41 skills from mattpocock/skills
- Cleanup unused imports (TouchInputService, Mouse, Camera)
- Bump version 1.6.64 -> 1.6.65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CRITICAL BUG] Locked dropdowns can be edited

2 participants